Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1535523003: [runtime] Drop FIRST/LAST_NONCALLABLE_SPEC_OBJECT instance type range. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Drop FIRST/LAST_NONCALLABLE_SPEC_OBJECT instance type range. The FIRST-LAST_NONCALLABLE_SPEC_OBJECT_TYPE range was accidentially used in field type tracking, where we should check for JSReceiver instead (there's no need to exclude JSProxy or JSFunction from tracking). And the use in %_ClassOf was actually wrong and didn't match the C++ implementation in JSReceiver::class_name() anymore. Now it's consistent again. R=yangguo@chromium.org BUG=chromium:535408 LOG=n Committed: https://chromium.googlesource.com/v8/v8/+/aafc3e54848af981f02b076cc9cfe7e54a67ad6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -253 lines) Patch
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 chunk +0 lines, -26 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -19 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -17 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +3 lines, -18 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +3 lines, -16 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -18 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +15 lines, -24 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +17 lines, -26 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Benedikt Meurer
5 years ago (2015-12-17 05:44:03 UTC) #1
Yang
lgtm
5 years ago (2015-12-17 05:49:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535523003/1
5 years ago (2015-12-17 06:01:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aafc3e54848af981f02b076cc9cfe7e54a67ad6d Cr-Commit-Position: refs/heads/master@{#32926}
5 years ago (2015-12-17 06:20:09 UTC) #7
Benedikt Meurer
5 years ago (2015-12-17 06:20:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aafc3e54848af981f02b076cc9cfe7e54a67ad6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698