third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.h - Issue 1535523002: Web Animations: Add SVGLengthListInterpolationType

Unified Diff: third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.h

Issue 1535523002: Web Animations: Add SVGLengthListInterpolationType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-dx-dy-composition.html ('K') | « third_party/WebKit/Source/core/animation/ListSVGInterpolation.h ('k') | third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp » ('j') | third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.h

diff --git a/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.h b/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.h

index d9b42ce52d7174b634bb4317b3884207bf64c145..c9d699c939030b1afdd1194be6c86eb67fb646c0 100644

--- a/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.h

+++ b/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.h

@@ -6,7 +6,6 @@

#define SVGLengthInterpolationType_h

#include "core/animation/SVGInterpolationType.h"

#include "core/svg/SVGLength.h"

namespace blink {

@@ -14,6 +13,10 @@ namespace blink {

class SVGLengthContext;

enum class SVGLengthMode;

+InterpolationComponent neutralInterpolableSVGLength();

alancutter (OOO until 2018) 2015/12/18 00:35:50 Global functions like this aren't consistent with

+InterpolationComponent interpolableSVGLength(const SVGLength&);

+PassRefPtrWillBeRawPtr<SVGLength> applyInterpolableSVGLength(const InterpolableValue&, const SVGLengthContext&, const SVGLengthMode&, bool);

alancutter (OOO until 2018) 2015/12/18 00:35:50 This doesn't actually apply anything, I'd call it

class SVGLengthInterpolationType : public SVGInterpolationType {

public:

SVGLengthInterpolationType(const QualifiedName& attribute)

@@ -26,7 +29,6 @@ private:

PassOwnPtr<InterpolationValue> maybeConvertNeutral(const UnderlyingValue&, ConversionCheckers&) const final;

PassOwnPtr<InterpolationValue> maybeConvertSVGValue(const SVGPropertyBase& svgValue) const final;

PassRefPtrWillBeRawPtr<SVGPropertyBase> appliedSVGValue(const InterpolableValue&, const NonInterpolableValue*) const final;

- PassRefPtrWillBeRawPtr<SVGPropertyBase> appliedSVGValue(const InterpolableValue&, const NonInterpolableValue*, const SVGLengthContext&) const;

void apply(const InterpolableValue&, const NonInterpolableValue*, InterpolationEnvironment&) const final;

const SVGLengthMode m_unitMode;