Issue 1535513002: Fix get_cpu_profile_timeline_rpc_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1535513002: Fix get_cpu_profile_timeline_rpc_test. (Closed)

Created:
5 years ago by rmacnak

Modified:
5 years ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix get_cpu_profile_timeline_rpc_test. AddProperty64 encodes as a JSON integer, not a JSON string. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/55a22037fb22631f460de7f0a20eb4a5a29fe8c9

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	runtime/observatory/tests/service/get_cpu_profile_timeline_rpc_test.dart	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
	M	runtime/vm/service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

5 years ago (2015-12-16 21:42:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
55a22037fb22631f460de7f0a20eb4a5a29fe8c9 (presubmit successful).