Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1535443003: update CMake and Google3 builds for AVX/AVX2 (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

update CMake and Google3 builds for AVX/AVX2 The _avx.cpp code was working in a degraded (SSE2/SSSE3) mode silently. This CL will make the _avx.cpp code start using AVX. There is currently no _avx2.cpp code, but I'm writing some now, and this change will make it work properly from the start. Chrome and Android builds should already be okay. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1535443003 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/f6d8d28883755d4ded224207b634a08367ee006f

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M BUILD.public View 6 chunks +36 lines, -0 lines 0 comments Download
M cmake/CMakeLists.txt View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535443003/1
5 years ago (2015-12-17 16:29:51 UTC) #5
mtklein_C
5 years ago (2015-12-17 16:35:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-17 16:44:38 UTC) #9
dogben
lgtm BUILD.public LGTM, no clue on CMake, but it seems reasonable. https://codereview.chromium.org/1535443003/diff/1/cmake/CMakeLists.txt File cmake/CMakeLists.txt (right): ...
5 years ago (2015-12-17 17:27:10 UTC) #10
mtklein
https://codereview.chromium.org/1535443003/diff/1/cmake/CMakeLists.txt File cmake/CMakeLists.txt (right): https://codereview.chromium.org/1535443003/diff/1/cmake/CMakeLists.txt#newcode117 cmake/CMakeLists.txt:117: # Certain files must be compiled with support for ...
5 years ago (2015-12-17 18:02:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535443003/20001
5 years ago (2015-12-17 18:02:29 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-17 18:18:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f6d8d28883755d4ded224207b634a08367ee006f

Powered by Google App Engine
This is Rietveld 408576698