Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 153543003: Files.app: Open drive apps in the current desktop. (Closed)

Created:
6 years, 10 months ago by hirono
Modified:
6 years, 10 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Files.app: Open drive apps in the current desktop. Previously, files.app opens drive apps in the desktop of the running profile. This CL adds lines to move the opened browser to the active desktop. BUG=336093 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/chromeos/drive/file_task_executor.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
hirono
PTAL the CL? Thanks!
6 years, 10 months ago (2014-02-04 06:57:30 UTC) #1
kinaba
On 2014/02/04 06:57:30, hirono wrote: > PTAL the CL? Thanks! Hmm, not sure if this ...
6 years, 10 months ago (2014-02-04 07:11:37 UTC) #2
hirono
On 2014/02/04 07:11:37, kinaba wrote: > On 2014/02/04 06:57:30, hirono wrote: > > PTAL the ...
6 years, 10 months ago (2014-02-04 07:18:37 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 07:18:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
6 years, 10 months ago (2014-02-04 07:19:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 07:48:23 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222920
6 years, 10 months ago (2014-02-04 07:48:23 UTC) #7
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 07:48:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
6 years, 10 months ago (2014-02-04 07:50:41 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 08:53:08 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120591
6 years, 10 months ago (2014-02-04 08:53:08 UTC) #11
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 12:36:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
6 years, 10 months ago (2014-02-04 12:37:06 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 13:35:41 UTC) #14
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120751
6 years, 10 months ago (2014-02-04 13:35:41 UTC) #15
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 15:02:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
6 years, 10 months ago (2014-02-04 15:03:56 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 16:09:04 UTC) #18
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120854
6 years, 10 months ago (2014-02-04 16:09:05 UTC) #19
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 16:09:06 UTC) #20
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-05 02:38:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
6 years, 10 months ago (2014-02-05 03:44:02 UTC) #22
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 06:56:27 UTC) #23
Message was sent while issue was closed.
Change committed as 248888

Powered by Google App Engine
This is Rietveld 408576698