|
|
Created:
6 years, 10 months ago by hirono Modified:
6 years, 10 months ago Reviewers:
kinaba CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionFiles.app: Open drive apps in the current desktop.
Previously, files.app opens drive apps in the desktop of the running profile.
This CL adds lines to move the opened browser to the active desktop.
BUG=336093
TEST=manually
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248888
Patch Set 1 #
Messages
Total messages: 23 (0 generated)
PTAL the CL? Thanks!
On 2014/02/04 06:57:30, hirono wrote: > PTAL the CL? Thanks! Hmm, not sure if this is good enough (teleporting all tabs together!?) but it looks http://crrev.com/248389 is taking the same approach, and I don't know better way. lgtm as a temporal solution. we might want to seek better way in the future...
On 2014/02/04 07:11:37, kinaba wrote: > On 2014/02/04 06:57:30, hirono wrote: > > PTAL the CL? Thanks! > > Hmm, not sure if this is good enough (teleporting all tabs together!?) > but it looks http://crrev.com/248389 is taking the same approach, and > I don't know better way. > > lgtm as a temporal solution. we might want to seek better way in the future... Got it. crbug.com/340585. Thanks!
The CQ bit was checked by hirono@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
The CQ bit was checked by hirono@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
The CQ bit was checked by hirono@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
The CQ bit was checked by hirono@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
CQ bit was unchecked on CL. Ignoring.
The CQ bit was checked by hirono@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153543003/1
Message was sent while issue was closed.
Change committed as 248888 |