third_party/WebKit/Source/core/dom/Range.h - Issue 1535403002: Cleanup return values in DOM Range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Range.h

Issue 1535403002: Cleanup return values in DOM Range. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Range.h

diff --git a/third_party/WebKit/Source/core/dom/Range.h b/third_party/WebKit/Source/core/dom/Range.h

index 0a8bed0a1df604c58ae4e578a2d3e0c4ba19758f..70aee6383ce41ebfbf50432b41ef500ca6c56f69 100644

--- a/third_party/WebKit/Source/core/dom/Range.h

+++ b/third_party/WebKit/Source/core/dom/Range.h

@@ -113,8 +113,8 @@ public:

void surroundContents(PassRefPtrWillBeRawPtr<Node>, ExceptionState&);

void setStartBefore(Node*, ExceptionState& = ASSERT_NO_EXCEPTION);

- const Position startPosition() const { return m_start.toPosition(); }

- const Position endPosition() const { return m_end.toPosition(); }

+ const Position& startPosition() const { return m_start.toPosition(); }

+ const Position& endPosition() const { return m_end.toPosition(); }

void setStart(const Position&, ExceptionState& = ASSERT_NO_EXCEPTION);

void setEnd(const Position&, ExceptionState& = ASSERT_NO_EXCEPTION);

« AUTHORS ('K') | « AUTHORS ('k') | no next file » | no next file with comments »