docs: explain how to preview changes

docs: explain how to preview changes

Your own changes or someone else's.

R=jyasskin@chromium.org,
BUG=571125
Committed: https://crrev.com/6efa499a1284f200785f3374b991e7d73adbe235
Cr-Commit-Position: refs/heads/master@{#366287}

[Jeffrey Yasskin, 2015-12-18 23:54:21]

https://codereview.chromium.org/1535273002/diff/20001/docs/README.md
File docs/README.md (right):

https://codereview.chromium.org/1535273002/diff/20001/docs/README.md#newcode17
docs/README.md:17: python tools/md_browser/md_browser.py
While this is running, http://localhost:8080/ gives me "I do not know how to
serve /.", and http://localhost:8080/docs/ gives me "I do not know how to serve
/docs/.".

[nodir, 2015-12-19 00:17:39]

nodir@chromium.org changed reviewers:
+ dpranke@chromium.org

[nodir, 2015-12-19 00:18:15]

https://codereview.chromium.org/1535273002/diff/20001/docs/README.md
File docs/README.md (right):

https://codereview.chromium.org/1535273002/diff/20001/docs/README.md#newcode17
docs/README.md:17: python tools/md_browser/md_browser.py
On 2015/12/18 at 23:54:21, Jeffrey Yasskin wrote:
> While this is running, http://localhost:8080/ gives me "I do not know how to
serve /.", and http://localhost:8080/docs/ gives me "I do not know how to serve
/docs/.".

I think md_browser should support file listing so it is easier to navigate
(+dpranke). With that, these instructions are enough.

Open http://localhost:8080/docs/README.md

[Jeffrey Yasskin, 2015-12-19 00:24:15]

https://codereview.chromium.org/1535273002/diff/20001/docs/README.md
File docs/README.md (right):

https://codereview.chromium.org/1535273002/diff/20001/docs/README.md#newcode17
docs/README.md:17: python tools/md_browser/md_browser.py
On 2015/12/19 00:18:15, nodir wrote:
> On 2015/12/18 at 23:54:21, Jeffrey Yasskin wrote:
> > While this is running, http://localhost:8080/ gives me "I do not know how to
> serve /.", and http://localhost:8080/docs/ gives me "I do not know how to
serve
> /docs/.".
> 
> I think md_browser should support file listing so it is easier to navigate
> (+dpranke). With that, these instructions are enough.
> 
> Open http://localhost:8080/docs/README.md

Once md_browser supports file listing, this lgtm.

[Jeffrey Yasskin, 2015-12-19 00:24:59]

On 2015/12/19 00:24:15, Jeffrey Yasskin wrote:
> https://codereview.chromium.org/1535273002/diff/20001/docs/README.md
> File docs/README.md (right):
> 
> https://codereview.chromium.org/1535273002/diff/20001/docs/README.md#newcode17
> docs/README.md:17: python tools/md_browser/md_browser.py
> On 2015/12/19 00:18:15, nodir wrote:
> > On 2015/12/18 at 23:54:21, Jeffrey Yasskin wrote:
> > > While this is running, http://localhost:8080/ gives me "I do not know how
to
> > serve /.", and http://localhost:8080/docs/ gives me "I do not know how to
> serve
> > /docs/.".
> > 
> > I think md_browser should support file listing so it is easier to navigate
> > (+dpranke). With that, these instructions are enough.
> > 
> > Open http://localhost:8080/docs/README.md
> 
> Once md_browser supports file listing, this lgtm.

Although it is still sad that reviewers have to patch in the change in order to
review it. It'd be better for there to be a server somewhere that knows how to
preview a CL number.

[nodir, 2015-12-19 01:43:26]

On 2015/12/19 at 00:24:59, jyasskin wrote:
> On 2015/12/19 00:24:15, Jeffrey Yasskin wrote:
> > https://codereview.chromium.org/1535273002/diff/20001/docs/README.md
> > File docs/README.md (right):
> > 
> >
https://codereview.chromium.org/1535273002/diff/20001/docs/README.md#newcode17
> > docs/README.md:17: python tools/md_browser/md_browser.py
> > On 2015/12/19 00:18:15, nodir wrote:
> > > On 2015/12/18 at 23:54:21, Jeffrey Yasskin wrote:
> > > > While this is running, http://localhost:8080/ gives me "I do not know
how to
> > > serve /.", and http://localhost:8080/docs/ gives me "I do not know how to
> > serve
> > > /docs/.".
> > > 
> > > I think md_browser should support file listing so it is easier to navigate
> > > (+dpranke). With that, these instructions are enough.
> > > 
> > > Open http://localhost:8080/docs/README.md
> > 
> > Once md_browser supports file listing, this lgtm.
> 
> Although it is still sad that reviewers have to patch in the change in order
to review it. It'd be better for there to be a server somewhere that knows how
to preview a CL number.

I agree that it is sad.

[nodir, 2015-12-19 01:45:19]

On 2015/12/19 at 01:43:26, nodir wrote:
> On 2015/12/19 at 00:24:59, jyasskin wrote:
> > On 2015/12/19 00:24:15, Jeffrey Yasskin wrote:
> > > https://codereview.chromium.org/1535273002/diff/20001/docs/README.md
> > > File docs/README.md (right):
> > > 
> > >
https://codereview.chromium.org/1535273002/diff/20001/docs/README.md#newcode17
> > > docs/README.md:17: python tools/md_browser/md_browser.py
> > > On 2015/12/19 00:18:15, nodir wrote:
> > > > On 2015/12/18 at 23:54:21, Jeffrey Yasskin wrote:
> > > > > While this is running, http://localhost:8080/ gives me "I do not know
how to
> > > > serve /.", and http://localhost:8080/docs/ gives me "I do not know how
to
> > > serve
> > > > /docs/.".
> > > > 
> > > > I think md_browser should support file listing so it is easier to
navigate
> > > > (+dpranke). With that, these instructions are enough.
> > > > 
> > > > Open http://localhost:8080/docs/README.md
> > > 
> > > Once md_browser supports file listing, this lgtm.
> > 
> > Although it is still sad that reviewers have to patch in the change in order
to review it. It'd be better for there to be a server somewhere that knows how
to preview a CL number.
> 
> I agree that it is sad.

There is no plan to add it to Rietveld because there is a plan to move code
review to Gerrit+Gitiles which is the thing that renders markdown.

[Dirk Pranke, 2015-12-19 19:52:11]

I agree that md_browser should support file listings. I haven't gotten around to
it yet, but it should be easy enough to add.

lgtm w/ or w/o the file listings.

[nodir, 2015-12-19 22:49:46]

On 2015/12/19 at 19:52:11, dpranke wrote:
> I agree that md_browser should support file listings. I haven't gotten around
to it yet, but it should be easy enough to add.
> 
> lgtm w/ or w/o the file listings.

jyasskin, README.md is clearly better with this change than without. From the
referenced documentation
(https://chromium.googlesource.com/chromium/src/+/master/tools/md_browser/), a
user can figure out how to open a file.
The UX of md_browser will improve.

[nodir, 2015-12-19 22:49:57]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2015-12-19 22:50:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535273002/20001

[commit-bot: I haz the power, 2015-12-20 00:54:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-20 00:55:44]

Description was changed from

==========
docs: explain how to preview changes

Your own changes or someone else's.

R=jyasskin@chromium.org,
BUG=571125
==========

to

==========
docs: explain how to preview changes

Your own changes or someone else's.

R=jyasskin@chromium.org,
BUG=571125

Committed: https://crrev.com/6efa499a1284f200785f3374b991e7d73adbe235
Cr-Commit-Position: refs/heads/master@{#366287}
==========

[commit-bot: I haz the power, 2015-12-20 00:55:45]

Patchset 2 (id:??) landed as
https://crrev.com/6efa499a1284f200785f3374b991e7d73adbe235
Cr-Commit-Position: refs/heads/master@{#366287}