Call bubble delegate Close function when bubble is closed by tab

Call bubble delegate Close function when bubble is closed by tab
closing, switching, etc.

This patch added code to call bubble delegate Close when bubble is
closed by tab closing, switching, etc. (instead of being caused by
the Connect/Cancel button is pressed).

BUG=492204
Committed: https://crrev.com/0fb3bf0999836d2c383a7952225d793187c4201e
Cr-Commit-Position: refs/heads/master@{#366472}

[juncai, 2015-12-18 17:31:42]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org

[juncai, 2015-12-18 17:31:42]

Please review this patch.

[juncai, 2015-12-21 20:00:56]

ping rsesek@, :).

[Robert Sesek, 2015-12-21 21:22:18]

LGTM % nit

https://codereview.chromium.org/1535183002/diff/1/chrome/browser/ui/cocoa/web...
File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
(right):

https://codereview.chromium.org/1535183002/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:141:
buttonPressed_ = false;
Can remove, ObjC objects are zero-initialized.

[juncai, 2015-12-21 21:38:04]

https://codereview.chromium.org/1535183002/diff/1/chrome/browser/ui/cocoa/web...
File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
(right):

https://codereview.chromium.org/1535183002/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:141:
buttonPressed_ = false;
On 2015/12/21 21:22:17, Robert Sesek wrote:
> Can remove, ObjC objects are zero-initialized.

Done.

[juncai, 2015-12-21 22:16:41]

The CQ bit was checked by juncai@chromium.org

[juncai, 2015-12-21 22:16:42]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1535183002/#ps20001
(title: "address rsesek@'s comments")

[commit-bot: I haz the power, 2015-12-21 22:17:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535183002/20001

[commit-bot: I haz the power, 2015-12-21 22:22:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-21 22:23:33]

Description was changed from

==========
Call bubble delegate Close function when bubble is closed by tab
closing, switching, etc.

This patch added code to call bubble delegate Close when bubble is
closed by tab closing, switching, etc. (instead of being caused by
the Connect/Cancel button is pressed).

BUG=492204
==========

to

==========
Call bubble delegate Close function when bubble is closed by tab
closing, switching, etc.

This patch added code to call bubble delegate Close when bubble is
closed by tab closing, switching, etc. (instead of being caused by
the Connect/Cancel button is pressed).

BUG=492204

Committed: https://crrev.com/0fb3bf0999836d2c383a7952225d793187c4201e
Cr-Commit-Position: refs/heads/master@{#366472}
==========

[commit-bot: I haz the power, 2015-12-21 22:23:34]

Patchset 2 (id:??) landed as
https://crrev.com/0fb3bf0999836d2c383a7952225d793187c4201e
Cr-Commit-Position: refs/heads/master@{#366472}