Rejigger distance field path rect calcs to avoid underflow

Rejigger distance field path rect calcs to avoid underflow

BUG=skia:4716
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1535173002

Committed: https://skia.googlesource.com/skia/+/ecbed9d01bdb7906e4a85bebd3e5b6b23fbacedf

[jvanverth1, 2015-12-18 16:36:37]

Description was changed from

==========
Rejigger distance field path rect calcs to avoid underflow

BUG=skia:4716
==========

to

==========
Rejigger distance field path rect calcs to avoid underflow

BUG=skia:4716
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2015-12-18 16:37:21]

jvanverth@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-12-18 17:36:45]

https://codereview.chromium.org/1535173002/diff/20001/src/gpu/batches/GrAADis...
File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/1535173002/diff/20001/src/gpu/batches/GrAADis...
src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:353:
devPathBounds.outset(intPad, intPad);
I guess this could still overflow if width or height is = int_max.  Do we not
care about that case?

[jvanverth1, 2015-12-18 17:48:43]

https://codereview.chromium.org/1535173002/diff/20001/src/gpu/batches/GrAADis...
File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/1535173002/diff/20001/src/gpu/batches/GrAADis...
src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:353:
devPathBounds.outset(intPad, intPad);
On 2015/12/18 17:36:45, joshualitt wrote:
> I guess this could still overflow if width or height is = int_max.  Do we not
> care about that case?

We've already caught that case in canDraw() -- we won't try to atlas a path that
big.

[joshualitt, 2015-12-18 17:49:04]

On 2015/12/18 17:48:43, jvanverth1 wrote:
>
https://codereview.chromium.org/1535173002/diff/20001/src/gpu/batches/GrAADis...
> File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):
> 
>
https://codereview.chromium.org/1535173002/diff/20001/src/gpu/batches/GrAADis...
> src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:353:
> devPathBounds.outset(intPad, intPad);
> On 2015/12/18 17:36:45, joshualitt wrote:
> > I guess this could still overflow if width or height is = int_max.  Do we
not
> > care about that case?
> 
> We've already caught that case in canDraw() -- we won't try to atlas a path
that
> big.

lgtm

[jvanverth1, 2015-12-18 17:49:38]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2015-12-18 17:49:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535173002/20001

[commit-bot: I haz the power, 2015-12-18 18:07:54]

Description was changed from

==========
Rejigger distance field path rect calcs to avoid underflow

BUG=skia:4716
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Rejigger distance field path rect calcs to avoid underflow

BUG=skia:4716
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ecbed9d01bdb7906e4a85bebd3e5b6b23fbacedf
==========

[commit-bot: I haz the power, 2015-12-18 18:07:54]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ecbed9d01bdb7906e4a85bebd3e5b6b23fbacedf