Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1535143002: Reland of Add test for previously unflattenables (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of Add test for previously unflattenables (patchset #1 id:1 of https://codereview.chromium.org/1532753002/ ) Reason for revert: The test should now be blacklisted. Original issue's description: > Revert of Add test for previously unflattenables (patchset #1 id:1 of https://codereview.chromium.org/1514373003/ ) > > Reason for revert: > Speculative fix for skbug.com/4709 > > Original issue's description: > > Add test for previously unflattenables > > > > BUG=skia:4613 > > > > Committed: https://skia.googlesource.com/skia/+/061aaa79f7d8a2e93962e8296abaae13f0a7a715 > > TBR=halcanary@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:4613 > > Committed: https://skia.googlesource.com/skia/+/c8f969309cafebeb16ad057f766b61bdc406a8b8 TBR=halcanary@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4613 Committed: https://skia.googlesource.com/skia/+/56fbbfe609baf5a6a8e21615b4a78fe6a6e364e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A tests/FlattenableFactoryToName.cpp View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scroggo
Created Reland of Add test for previously unflattenables
5 years ago (2015-12-18 14:53:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535143002/1
5 years ago (2015-12-18 15:13:57 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-18 15:14:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/56fbbfe609baf5a6a8e21615b4a78fe6a6e364e0

Powered by Google App Engine
This is Rietveld 408576698