Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1535133002: Reenable testing webp to PDF on Valgrind (Closed)

Created:
5 years ago by scroggo
Modified:
4 years, 11 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@reenableTest3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reenable testing webp to PDF on Valgrind The errors were probably due to skbug.com/4038, which has been fixed. Reenable the test. BUG=skia:3505 BUG=skia:4038 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1535133002 Committed: https://skia.googlesource.com/skia/+/3e07d94c95fe3a66245f362996e0e530613ad2a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M tools/dm_flags.json View 2 chunks +0 lines, -8 lines 0 comments Download
M tools/dm_flags.py View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
scroggo
4 years, 11 months ago (2016-01-04 16:08:58 UTC) #3
hal.canary
lgtm, if you've shown it works locally.
4 years, 11 months ago (2016-01-04 21:07:58 UTC) #4
scroggo
On 2016/01/04 at 21:07:58, halcanary wrote: > lgtm, if you've shown it works locally. The ...
4 years, 11 months ago (2016-01-06 19:08:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535133002/1
4 years, 11 months ago (2016-01-06 19:08:31 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 19:28:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3e07d94c95fe3a66245f362996e0e530613ad2a9

Powered by Google App Engine
This is Rietveld 408576698