Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1535063003: Revert of [Tracing] Adjust allocation register size for low-end devices (Closed)

Created:
5 years ago by phoglund_chromium
Modified:
5 years ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Tracing] Adjust allocation register size for low-end devices (patchset #4 id:60001 of https://codereview.chromium.org/1530583003/ ) Reason for revert: Breaks Win GN compile (warning C4267: 'argument' : conversion from 'size_t' to 'uint32_t', possible loss of data): https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9247/steps/compile/logs/stdio Original issue's description: > [Tracing] Adjust allocation register size for low-end devices > > This patch limits the size of the allocation register and prevents OOM > errors when running AllocationRegisterTest.OverflowDeathTest on low-end > devices. > > BUG=570242 > > Committed: https://crrev.com/684e479f9a46580b5d5bdcf58944b832f6317dc1 > Cr-Commit-Position: refs/heads/master@{#365905} TBR=primiano@chromium.org,ruuda@google.com,seantopping@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570242 Committed: https://crrev.com/a9f7ec25e3ec1d2c6c56fc0a8ce28980c1412d66 Cr-Commit-Position: refs/heads/master@{#366061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M base/trace_event/heap_profiler_allocation_register.h View 3 chunks +1 line, -6 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_register.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_register_unittest.cc View 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
phoglund_chromium
Created Revert of [Tracing] Adjust allocation register size for low-end devices
5 years ago (2015-12-18 09:00:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535063003/1
5 years ago (2015-12-18 09:00:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535063003/1
5 years ago (2015-12-18 09:02:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 09:03:11 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-18 09:04:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9f7ec25e3ec1d2c6c56fc0a8ce28980c1412d66
Cr-Commit-Position: refs/heads/master@{#366061}

Powered by Google App Engine
This is Rietveld 408576698