Issue 153503004: Add logging to CrossSiteResourceHandler and BufferedResourceHandler

Issue 153503004: Add logging to CrossSiteResourceHandler and BufferedResourceHandler (Closed)

Created:
6 years, 10 months ago by mmenke

Modified:
6 years, 10 months ago

Reviewers:
eroman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Add logging to CrossSiteResourceHandler and BufferedResourceHandler, when they block a URLRequest. BUG=294920 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251161

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
M	content/browser/loader/buffered_resource_handler.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/browser/loader/cross_site_resource_handler.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/loader/cross_site_resource_handler.cc	View	1 2	3 chunks	+9 lines, -2 lines	0 comments	Download

Total messages: 9 (0 generated)

mmenke

This CL was motivated (shockingly) by yet another case of a delegate blocking requests indefinitely.

6 years, 10 months ago (2014-02-05 18:55:27 UTC) #1

eroman

LGTM. What are your thoughts on generalizing the logging code so any new code that ...

6 years, 10 months ago (2014-02-06 22:33:17 UTC) #2

mmenke

On 2014/02/06 22:33:17, eroman wrote: > LGTM. > > What are your thoughts on generalizing ...

6 years, 10 months ago (2014-02-06 22:44:13 UTC) #3

mmenke

[+darin] For owner's review. Ran into a bug where this really would have helped. Be ...

6 years, 10 months ago (2014-02-10 16:21:54 UTC) #4

mmenke

[-darin] I'm now a content/browser/loader owner! The world will fall before me! Ahahahaha! Erm...pardon.

6 years, 10 months ago (2014-02-13 17:48:07 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/153503004/390001

6 years, 10 months ago (2014-02-13 17:50:24 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/153503004/390001

6 years, 10 months ago (2014-02-13 19:53:50 UTC) #8

Message was sent while issue was closed.

Change committed as 251161