Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 153503002: Make traffic shaping work when WPR chooses the server ports. (Closed)

Created:
6 years, 10 months ago by tonyg
Modified:
6 years, 10 months ago
Reviewers:
slamm
CC:
web-page-replay-dev_googlegroups.com
Visibility:
Public.

Description

Make traffic shaping work when WPR chooses the server ports. WPR may be invoked with ports of 0 to let WPR choose an ephemeral port. However, we weren't handling this properly and detecting the chosen port for traffic shaping. This CL fixes that by getting the actual port used. R=slamm@chromium.org Committed: https://code.google.com/p/web-page-replay/source/detail?r=540

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -40 lines) Patch
M dnsproxy.py View 1 chunk +1 line, -0 lines 0 comments Download
M replay.py View 3 chunks +2 lines, -28 lines 0 comments Download
M servermanager.py View 4 chunks +21 lines, -0 lines 0 comments Download
M trafficshaper.py View 1 4 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
ptal
6 years, 10 months ago (2014-02-04 05:10:47 UTC) #1
slamm
I like it! https://codereview.chromium.org/153503002/diff/1/trafficshaper.py File trafficshaper.py (right): https://codereview.chromium.org/153503002/diff/1/trafficshaper.py#newcode56 trafficshaper.py:56: ports=None, Nice simplification. https://codereview.chromium.org/153503002/diff/1/trafficshaper.py#newcode110 trafficshaper.py:110: ports ...
6 years, 10 months ago (2014-02-04 17:36:02 UTC) #2
tonyg
> https://codereview.chromium.org/153503002/diff/1/trafficshaper.py#newcode110 > trafficshaper.py:110: ports = ','.join([str(p) for p in self.ports]) > A generator works ...
6 years, 10 months ago (2014-02-04 17:42:21 UTC) #3
slamm
I lgtm it!
6 years, 10 months ago (2014-02-04 17:45:30 UTC) #4
tonyg
6 years, 10 months ago (2014-02-04 18:08:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r540 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698