Chromium Code Reviews
Help | Chromium Project | Sign in
(30)

Issue 1535016: We should also delete the underlying persistent public key... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by wtc
Modified:
3 years, 10 months ago
Reviewers:
Jens Alfke
CC:
chromium-reviews, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr., rsleevi-old
Visibility:
Public.

Description

We should delete the underlying persistent public key only when we cannot sign the challenge. This matches what Mozilla does. Fix nits. R=snej BUG=148 TEST=No compilation errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43524

Patch Set 1 #

Patch Set 2 : Make albertb's suggested changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M net/base/keygen_handler_nss.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/base/keygen_handler_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/keygen_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
wtc
5 years ago (2010-04-02 01:10:28 UTC) #1
Jens Alfke
5 years ago (2010-04-02 16:55:18 UTC) #2
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d