Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 15350002: Deprecate kAshDisableNewNetworkStatusArea (Closed)

Created:
7 years, 7 months ago by stevenjb
Modified:
7 years, 7 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Deprecate kAshDisableNewNetworkStatusArea Eliminates NetworkListDetailedView and dependencies. This mostly removes dead code, but also fixes the following issues related to the old code: * TrayNetwork::OnWillToggleWifi() -> TrayNetwork::RequestToggleWifi() to toggle wifi directly from Ash. * Implement TrayNetwork::NetworkManagerChanged() so that detailed views are notified when technology state changes. * Eliminates unnecessary ash::SystemTrayDelegate dependencies on network_menu_ when using new connection handler code. BUG=240859 For about_network.cc: TBR=jamescook@chromium.org, jennyz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201322

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : Cleanup includes #

Patch Set 4 : Rebase #

Patch Set 5 : Fix clang errors #

Patch Set 6 : . #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -1915 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ash/ash.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/system/chromeos/network/network_detailed_view.h View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/chromeos/network/network_list_detailed_view.h View 1 chunk +0 lines, -74 lines 0 comments Download
D ash/system/chromeos/network/network_list_detailed_view.cc View 1 chunk +0 lines, -287 lines 0 comments Download
D ash/system/chromeos/network/network_list_detailed_view_base.h View 1 chunk +0 lines, -118 lines 0 comments Download
D ash/system/chromeos/network/network_list_detailed_view_base.cc View 1 chunk +0 lines, -425 lines 0 comments Download
M ash/system/chromeos/network/network_observer.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/system/chromeos/network/network_state_notifier.cc View 1 2 3 chunks +1 line, -7 lines 0 comments Download
M ash/system/chromeos/network/tray_network.h View 1 2 3 4 3 chunks +1 line, -3 lines 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 1 2 3 4 5 13 chunks +65 lines, -92 lines 0 comments Download
M ash/system/chromeos/network/tray_network_state_observer.cc View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/tray_sms.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/tray_vpn.h View 1 2 3 chunks +0 lines, -14 lines 0 comments Download
M ash/system/chromeos/network/tray_vpn.cc View 1 2 3 4 5 8 chunks +23 lines, -184 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 2 3 chunks +1 line, -57 lines 0 comments Download
M ash/system/tray/system_tray_notifier.h View 4 chunks +1 line, -7 lines 0 comments Download
M ash/system/tray/system_tray_notifier.cc View 3 chunks +2 lines, -22 lines 0 comments Download
M ash/system/tray/test_system_tray_delegate.h View 1 2 2 chunks +0 lines, -23 lines 0 comments Download
M ash/system/tray/test_system_tray_delegate.cc View 1 2 3 chunks +1 line, -73 lines 0 comments Download
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 3 4 16 chunks +16 lines, -333 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/about_network.cc View 3 chunks +1 line, -162 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
stevenjb
jennyz@ - Primary reviewer jamescook@ - owner for ash/ and chrome/browser/ui/ash/ gspencer@ - Mostly FYI
7 years, 7 months ago (2013-05-17 23:53:05 UTC) #1
jennyz
lgtm with a nit. Excellent, so glad to see the code has been simplified so ...
7 years, 7 months ago (2013-05-20 20:46:17 UTC) #2
James Cook
LGTM with nits. Hooray for code deletion! https://codereview.chromium.org/15350002/diff/3001/ash/system/chromeos/network/tray_vpn.cc File ash/system/chromeos/network/tray_vpn.cc (right): https://codereview.chromium.org/15350002/diff/3001/ash/system/chromeos/network/tray_vpn.cc#newcode7 ash/system/chromeos/network/tray_vpn.cc:7: #include "ash/ash_switches.h" ...
7 years, 7 months ago (2013-05-20 21:06:16 UTC) #3
stevenjb
https://codereview.chromium.org/15350002/diff/3001/ash/system/chromeos/network/tray_vpn.cc File ash/system/chromeos/network/tray_vpn.cc (right): https://codereview.chromium.org/15350002/diff/3001/ash/system/chromeos/network/tray_vpn.cc#newcode7 ash/system/chromeos/network/tray_vpn.cc:7: #include "ash/ash_switches.h" On 2013/05/20 21:06:16, James Cook (Chromium) wrote: ...
7 years, 7 months ago (2013-05-20 21:16:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/15350002/27001
7 years, 7 months ago (2013-05-20 23:33:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=3838
7 years, 7 months ago (2013-05-20 23:46:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/15350002/27001
7 years, 7 months ago (2013-05-21 00:44:18 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-21 01:08:13 UTC) #8
stevenjb
7 years, 7 months ago (2013-05-21 17:07:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #7 manually as r201322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698