Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3047)

Unified Diff: net/socket/socket_test_util.h

Issue 1534993003: Remove use of DeterministicSocketData from QUIC tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge... Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.h
diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h
index 6a7719528b61ddabb45c41e56e6da745a4f7d379..73e73a0e236607ed0dcf6a4b1c4972a418eaaff1 100644
--- a/net/socket/socket_test_util.h
+++ b/net/socket/socket_test_util.h
@@ -665,9 +665,16 @@ class MockClientSocketFactory : public ClientSocketFactory {
const SSLClientSocketContext& context) override;
void ClearSSLSessionCache() override;
+ const std::vector<uint16>& udp_client_socket_ports() const {
+ return udp_client_socket_ports_;
+ }
+
private:
SocketDataProviderArray<SocketDataProvider> mock_data_;
SocketDataProviderArray<SSLSocketDataProvider> mock_ssl_data_;
+ std::vector<uint16> udp_client_socket_ports_;
+
+ DISALLOW_COPY_AND_ASSIGN(MockClientSocketFactory);
};
class MockClientSocket : public SSLClientSocket {
@@ -845,55 +852,6 @@ class DeterministicSocketHelper {
BoundNetLog net_log_;
};
-// Mock UDP socket to be used in conjunction with DeterministicSocketData.
-class DeterministicMockUDPClientSocket
- : public DatagramClientSocket,
- public DeterministicSocketData::Delegate,
- public base::SupportsWeakPtr<DeterministicMockUDPClientSocket> {
- public:
- DeterministicMockUDPClientSocket(net::NetLog* net_log,
- DeterministicSocketData* data);
- ~DeterministicMockUDPClientSocket() override;
-
- // DeterministicSocketData::Delegate:
- bool WritePending() const override;
- bool ReadPending() const override;
- void CompleteWrite() override;
- int CompleteRead() override;
-
- // Socket implementation.
- int Read(IOBuffer* buf,
- int buf_len,
- const CompletionCallback& callback) override;
- int Write(IOBuffer* buf,
- int buf_len,
- const CompletionCallback& callback) override;
- int SetReceiveBufferSize(int32 size) override;
- int SetSendBufferSize(int32 size) override;
-
- // DatagramSocket implementation.
- void Close() override;
- int GetPeerAddress(IPEndPoint* address) const override;
- int GetLocalAddress(IPEndPoint* address) const override;
- const BoundNetLog& NetLog() const override;
-
- // DatagramClientSocket implementation.
- int BindToNetwork(NetworkChangeNotifier::NetworkHandle network) override;
- int BindToDefaultNetwork() override;
- NetworkChangeNotifier::NetworkHandle GetBoundNetwork() override;
- int Connect(const IPEndPoint& address) override;
-
- void set_source_port(uint16 port) { source_port_ = port; }
-
- private:
- bool connected_;
- IPEndPoint peer_address_;
- DeterministicSocketHelper helper_;
- uint16 source_port_; // Ephemeral source port.
-
- DISALLOW_COPY_AND_ASSIGN(DeterministicMockUDPClientSocket);
-};
-
// Mock TCP socket to be used in conjunction with DeterministicSocketData.
class DeterministicMockTCPClientSocket
: public MockClientSocket,
@@ -1020,6 +978,7 @@ class MockUDPClientSocket : public DatagramClientSocket, public AsyncSocket {
void OnDataProviderDestroyed() override;
void set_source_port(uint16 port) { source_port_ = port;}
+ uint16 source_port() const { return source_port_; }
private:
int CompleteRead();
@@ -1224,9 +1183,6 @@ class DeterministicMockClientSocketFactory : public ClientSocketFactory {
std::vector<DeterministicMockTCPClientSocket*>& tcp_client_sockets() {
return tcp_client_sockets_;
}
- std::vector<DeterministicMockUDPClientSocket*>& udp_client_sockets() {
- return udp_client_sockets_;
- }
// ClientSocketFactory
scoped_ptr<DatagramClientSocket> CreateDatagramClientSocket(
@@ -1251,7 +1207,6 @@ class DeterministicMockClientSocketFactory : public ClientSocketFactory {
// Store pointers to handed out sockets in case the test wants to get them.
std::vector<DeterministicMockTCPClientSocket*> tcp_client_sockets_;
- std::vector<DeterministicMockUDPClientSocket*> udp_client_sockets_;
std::vector<MockSSLClientSocket*> ssl_client_sockets_;
DISALLOW_COPY_AND_ASSIGN(DeterministicMockClientSocketFactory);
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698