Remove use of DeterministicSocketData from QUIC tests.

Remove use of DeterministicSocketData from QUIC tests.

This switches them over to using SequencedSocketData, and removes
support for using DeterministicSocketData with UDP sockets.

BUG=492693
Committed: https://crrev.com/651bae7f9f979129ce3f662fe4dafe2327da0c88
Cr-Commit-Position: refs/heads/master@{#366169}

[mmenke, 2015-12-18 17:37:53]

mmenke@chromium.org changed reviewers:
+ rch@chromium.org

[mmenke, 2015-12-18 17:37:53]

After this, just 3 more files used the DeterministicSocketData.  I believe two
run into a SPDY proxy bug, though.

https://codereview.chromium.org/1534993003/diff/20001/net/quic/quic_network_t...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1534993003/diff/20001/net/quic/quic_network_t...
net/quic/quic_network_transaction_unittest.cc:1375:
ASSERT_TRUE(quic_data.AllReadDataConsumed());
Note that the "SYCHRONOUS" write, which the ordering implied should happen
before the read, was never being started in these tests. 
DeterministicSocketData just didn't care.

I flipped the order, and fixed the check that all read data is consumed.  Not
really sure if the write is supposed to happen or not, so didn't add any check
for it, one way or the other.

https://codereview.chromium.org/1534993003/diff/20001/net/quic/quic_stream_fa...
File net/quic/quic_stream_factory_test.cc (right):

https://codereview.chromium.org/1534993003/diff/20001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory_test.cc:204: MockRead reads[] =
{MockRead(SYNCHRONOUS, ERR_IO_PENDING, 0)};
This operation was never completed, since the DeterministicSocketData was never
being Run().

https://codereview.chromium.org/1534993003/diff/20001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory_test.cc:965: MockRead(SYNCHRONOUS, ERR_IO_PENDING,
2)};
Because this was calling RunFor(2) before, the final mock read was being
started, but the OK was never actually being read from the socket. 
AllReadDataConsumed() for DeterministicSocketData actually checks that the last
read *started* not that it *completed*.

If this test really is supposed to read the EOF from the socket, then it should
be updated - we write another reset packet on the "EOF" (Is that even the right
term for a 0-length UDP packet?)

Most of the other modified tests in this file were suffering from similar
issues.

[mmenke, 2015-12-18 18:04:30]

Description was changed from

==========
Remove use of DeterministicSocketData from QUIC tests.

This switches them over to using SequencedSocketData, and removes
support for using DeterministicSocketData with UDP sockets.

BUG=
==========

to

==========
Remove use of DeterministicSocketData from QUIC tests.

This switches them over to using SequencedSocketData, and removes
support for using DeterministicSocketData with UDP sockets.

BUG=492693
==========

[Ryan Hamilton, 2015-12-18 19:50:26]

Thanks for doing all the heavy lifting here!
LGTM

https://codereview.chromium.org/1534993003/diff/20001/net/quic/quic_stream_fa...
File net/quic/quic_stream_factory_test.cc (right):

https://codereview.chromium.org/1534993003/diff/20001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory_test.cc:965: MockRead(SYNCHRONOUS, ERR_IO_PENDING,
2)};
On 2015/12/18 17:37:53, mmenke (OOO Dec 19 to Jan 3) wrote:
> Because this was calling RunFor(2) before, the final mock read was being
> started, but the OK was never actually being read from the socket. 
> AllReadDataConsumed() for DeterministicSocketData actually checks that the
last
> read *started* not that it *completed*.
> 
> If this test really is supposed to read the EOF from the socket, then it
should
> be updated - we write another reset packet on the "EOF" (Is that even the
right
> term for a 0-length UDP packet?)
> 
> Most of the other modified tests in this file were suffering from similar
> issues.

Yeah, this test was "exploiting" RunFor(). Your fix is much better. Thank you!

https://codereview.chromium.org/1534993003/diff/20001/net/socket/socket_test_...
File net/socket/socket_test_util.h (left):

https://codereview.chromium.org/1534993003/diff/20001/net/socket/socket_test_...
net/socket/socket_test_util.h:849: class DeterministicMockUDPClientSocket
YES!!!!!

[mmenke, 2015-12-18 19:52:28]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2015-12-18 19:53:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534993003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534993003/20001

[commit-bot: I haz the power, 2015-12-18 19:59:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 19:59:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mmenke, 2015-12-18 20:07:01]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2015-12-18 20:07:01]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1534993003/#ps40001
(title: "Merge")

[commit-bot: I haz the power, 2015-12-18 20:07:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534993003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534993003/40001

[commit-bot: I haz the power, 2015-12-18 20:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 20:10:36]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2015-12-18 20:21:36]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2015-12-18 20:21:36]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1534993003/#ps60001
(title: "Merge...")

[commit-bot: I haz the power, 2015-12-18 20:21:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534993003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534993003/60001

[commit-bot: I haz the power, 2015-12-18 21:26:54]

Description was changed from

==========
Remove use of DeterministicSocketData from QUIC tests.

This switches them over to using SequencedSocketData, and removes
support for using DeterministicSocketData with UDP sockets.

BUG=492693
==========

to

==========
Remove use of DeterministicSocketData from QUIC tests.

This switches them over to using SequencedSocketData, and removes
support for using DeterministicSocketData with UDP sockets.

BUG=492693
==========

[commit-bot: I haz the power, 2015-12-18 21:26:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-18 21:27:37]

Description was changed from

==========
Remove use of DeterministicSocketData from QUIC tests.

This switches them over to using SequencedSocketData, and removes
support for using DeterministicSocketData with UDP sockets.

BUG=492693
==========

to

==========
Remove use of DeterministicSocketData from QUIC tests.

This switches them over to using SequencedSocketData, and removes
support for using DeterministicSocketData with UDP sockets.

BUG=492693

Committed: https://crrev.com/651bae7f9f979129ce3f662fe4dafe2327da0c88
Cr-Commit-Position: refs/heads/master@{#366169}
==========

[commit-bot: I haz the power, 2015-12-18 21:27:38]

Patchset 4 (id:??) landed as
https://crrev.com/651bae7f9f979129ce3f662fe4dafe2327da0c88
Cr-Commit-Position: refs/heads/master@{#366169}