cleanup and rename validateAndGenerateBuildAttributes

cleanup and rename validateAndGenerateBuildAttributes

there is no way for these values of build attributes to be other than 0,1 by c++ rules since they are constexpr bool.

BUG=
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5412eb7ddb7096a82de40d7463cf8a945afd9468

[rkotlerimgtec, 2015-12-18 22:06:10]

Description was changed from

==========
cleanup and rename validateAndGenerateBuildAttributes


BUG=
==========

to

==========
cleanup and rename validateAndGenerateBuildAttributes

there is no way for these values of build attributes to be other than 0,1 by c++
rules since they are constexpr bool.

BUG=
==========

[rkotlerimgtec, 2015-12-18 22:06:10]

rkotlerimgtec@gmail.com changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-12-19 16:12:54]

https://codereview.chromium.org/1534883005/diff/20001/src/IceCompiler.cpp
File src/IceCompiler.cpp (right):

https://codereview.chromium.org/1534883005/diff/20001/src/IceCompiler.cpp#new...
src/IceCompiler.cpp:56: /// Dumps values of build attributes to Stream if Stream
is
Reflow comment to 80-col

https://codereview.chromium.org/1534883005/diff/20001/src/IceCompiler.cpp#new...
src/IceCompiler.cpp:59: if (!Stream)
Stream == nullptr

I think the code base is inconsistent about "if (ptr)" versus "if (ptr !=
nullptr)", but pretty consistent about using "if (ptr == nullptr)" and not "if
(!ptr)".

https://codereview.chromium.org/1534883005/diff/20001/src/IceCompiler.cpp#new...
src/IceCompiler.cpp:67: const CBA &A = ConditionalBuildAttributes[i];
I think you can use "const auto &A" here, and thereby avoid the
otherwise-useless naming of that struct.  What do you think?

[rkotlerimgtec, 2015-12-21 02:51:31]

https://codereview.chromium.org/1534883005/diff/20001/src/IceCompiler.cpp
File src/IceCompiler.cpp (right):

https://codereview.chromium.org/1534883005/diff/20001/src/IceCompiler.cpp#new...
src/IceCompiler.cpp:56: /// Dumps values of build attributes to Stream if Stream
is
On 2015/12/19 16:12:54, stichnot wrote:
> Reflow comment to 80-col

Done.

https://codereview.chromium.org/1534883005/diff/20001/src/IceCompiler.cpp#new...
src/IceCompiler.cpp:59: if (!Stream)
On 2015/12/19 16:12:54, stichnot wrote:
> Stream == nullptr
> 
> I think the code base is inconsistent about "if (ptr)" versus "if (ptr !=
> nullptr)", but pretty consistent about using "if (ptr == nullptr)" and not "if
> (!ptr)".

Done.

https://codereview.chromium.org/1534883005/diff/20001/src/IceCompiler.cpp#new...
src/IceCompiler.cpp:67: const CBA &A = ConditionalBuildAttributes[i];
On 2015/12/19 16:12:54, stichnot wrote:
> I think you can use "const auto &A" here, and thereby avoid the
> otherwise-useless naming of that struct.  What do you think?

Done.

[rkotlerimgtec, 2015-12-22 19:58:11]

On 2015/12/22 01:02:20, rkotlerimgtec wrote:

I will remove the changes to src/CLFlags.cpp from this patch revision.

It was a mistake. My git repository was messed up. I have a separate patch for
that.

[rkotlerimgtec, 2015-12-22 20:03:33]

Patchset #3 (id:40001) has been deleted

[Jim Stichnoth, 2015-12-22 21:29:44]

lgtm

[Jim Stichnoth, 2015-12-22 21:32:03]

Description was changed from

==========
cleanup and rename validateAndGenerateBuildAttributes

there is no way for these values of build attributes to be other than 0,1 by c++
rules since they are constexpr bool.

BUG=
==========

to

==========
cleanup and rename validateAndGenerateBuildAttributes

there is no way for these values of build attributes to be other than 0,1 by c++
rules since they are constexpr bool.

BUG=
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2015-12-22 21:32:04]

Committed patchset #3 (id:60001) manually as
5412eb7ddb7096a82de40d7463cf8a945afd9468 (presubmit successful).