Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1534823002: tools/gn: delete generate_test_gn_data tool (Closed)

Created:
5 years ago by tfarina
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, tfarina, Dirk Pranke, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: delete generate_test_gn_data tool In the beginning, when gn was released, it was used to make performance tests, as we didn't have many BUILD.gn files. Now that we have hundreds of them in tree, this is not necessary, as the performance can be tested with real data. BUG=94925, 372642 R=brettw@chromium.org,dpranke@chromium.org Committed: https://crrev.com/8e5f41b25ac6af35715b61a5c2c70c99e4b05213 Cr-Commit-Position: refs/heads/master@{#368492}

Patch Set 1 #

Patch Set 2 : root level #

Patch Set 3 : fix gyp build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -150 lines) Patch
M BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/BUILD.gn View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
D tools/gn/generate_test_gn_data.cc View 1 2 1 chunk +0 lines, -127 lines 0 comments Download
M tools/gn/gn.gyp View 1 2 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
tfarina
5 years ago (2015-12-17 16:02:12 UTC) #1
tfarina
Brett, ping?
5 years ago (2015-12-22 02:08:46 UTC) #3
Dirk Pranke
lgtm assuming the trybot failures were unrelated.
5 years ago (2015-12-23 03:56:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534823002/20001
4 years, 12 months ago (2015-12-23 13:41:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131379) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 12 months ago (2015-12-23 13:44:58 UTC) #10
brettw
lgtm
4 years, 11 months ago (2016-01-08 18:12:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534823002/40001
4 years, 11 months ago (2016-01-08 22:56:43 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-09 00:52:41 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-09 00:53:27 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8e5f41b25ac6af35715b61a5c2c70c99e4b05213
Cr-Commit-Position: refs/heads/master@{#368492}

Powered by Google App Engine
This is Rietveld 408576698