Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1534783002: [Cast, Android, Presentation API] Implement ReceiverAction messages. (Closed)

Created:
5 years ago by whywhat
Modified:
5 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast, Android, Presentation API] Implement ReceiverAction messages. BUG=561470 TEST=manual with the YT experiment 1. Allow a route with a special presentation id to join a non-existing session to pass the CAST message back through. 2. Send the CAST message back via the special route before the route is being created with the selected device info. 3. Send the STOP message via the normal route when the session is about to close via the CloseRoute() or the notification controls. Committed: https://crrev.com/e96721f1f8484454c52a23b214a830a2ffa8f4eb Cr-Commit-Position: refs/heads/master@{#365900}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -40 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/router/RouteDelegate.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java View 12 chunks +100 lines, -38 lines 2 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/1534783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java File chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java (right): https://codereview.chromium.org/1534783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java#newcode452 chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:452: if (mSession != null) mSession.clientIds.add(clientId); nit: could be ...
5 years ago (2015-12-17 15:45:13 UTC) #2
whywhat
https://codereview.chromium.org/1534783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java File chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java (right): https://codereview.chromium.org/1534783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java#newcode452 chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:452: if (mSession != null) mSession.clientIds.add(clientId); On 2015/12/17 at 15:45:13, ...
5 years ago (2015-12-17 16:02:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534783002/1
5 years ago (2015-12-17 16:04:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/606)
5 years ago (2015-12-17 17:44:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534783002/1
5 years ago (2015-12-17 17:50:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/681)
5 years ago (2015-12-17 19:46:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534783002/1
5 years ago (2015-12-17 20:04:03 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 21:56:13 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-17 21:58:17 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e96721f1f8484454c52a23b214a830a2ffa8f4eb
Cr-Commit-Position: refs/heads/master@{#365900}

Powered by Google App Engine
This is Rietveld 408576698