Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1534663002: X87: [proxies] fix access issue when having proxies on the prototype-chain of global objects. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [proxies] fix access issue when having proxies on the prototype-chain of global objects. port 2c75e3d2abc3eba3337a09afcd0dfa3e653ff006 (r32903) original commit message: We can no longer just walk the prototype chain without doing proper access-checks. When installing a proxy as the __proto__ of the global object we might accidentally end up invoking cross-realm code without access-checks (see proxies-cross-realm-ecxeption.js). BUG= Committed: https://crrev.com/e0a3ff0f5c72e6c3eb74740c763465233e4b2c63 Cr-Commit-Position: refs/heads/master@{#32924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-17 02:33:54 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-17 02:34:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534663002/1
5 years ago (2015-12-17 02:35:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 04:48:14 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 04:48:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0a3ff0f5c72e6c3eb74740c763465233e4b2c63
Cr-Commit-Position: refs/heads/master@{#32924}

Powered by Google App Engine
This is Rietveld 408576698