Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1534623002: Mac CoreAnimation: Add more CALayer parameters (Closed)

Created:
5 years ago by ccameron
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cc-bugs_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, extensions-reviews_chromium.org, jam, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac CoreAnimation: Add more CALayer parameters Clipping and unsupported 3D intersections account for 20% of the frames that fail to be rendered by the CoreAnimation renderer. Add parameters to the GL extension to support these functions. Also add a parameter for edge anti-aliasing, since that will be needed in the future. TBR=ben BUG=533681 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d745f1ab5e11fab3fabdd47626ac4b39e9d42c2f Cr-Commit-Position: refs/heads/master@{#365965}

Patch Set 1 #

Patch Set 2 : Add text change #

Patch Set 3 : Fix windows compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -68 lines) Patch
M cc/output/gl_renderer.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt View 1 5 chunks +23 lines, -5 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 2 chunks +27 lines, -2 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 chunk +8 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +5 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +9 lines, -3 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 4 chunks +28 lines, -8 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +10 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 4 chunks +12 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.h View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M mojo/public/c/gles2/gles2_call_visitor_chromium_extension_autogen.h View 1 chunk +11 lines, -3 lines 0 comments Download
M ui/gl/gl_surface.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/gl/gl_surface.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
ccameron
Adding zmo@ for gpu/command_bbuffer/... Adding kbr@ for ui/gl/... Adding ben@ for mojo/...
5 years ago (2015-12-16 23:41:47 UTC) #3
Ken Russell (switch to Gerrit)
Please update src/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt . Thanks.
5 years ago (2015-12-17 00:55:57 UTC) #4
Ken Russell (switch to Gerrit)
ui/gl lgtm once the extension spec's been updated.
5 years ago (2015-12-17 01:05:06 UTC) #5
ccameron
On 2015/12/17 at 01:05:06, kbr wrote: > ui/gl lgtm once the extension spec's been updated. ...
5 years ago (2015-12-17 01:41:27 UTC) #6
Zhenyao Mo
On 2015/12/17 01:41:27, ccameron wrote: > On 2015/12/17 at 01:05:06, kbr wrote: > > ui/gl ...
5 years ago (2015-12-17 21:14:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534623002/20001
5 years ago (2015-12-17 21:21:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/146616)
5 years ago (2015-12-17 22:16:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534623002/40001
5 years ago (2015-12-17 23:37:54 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/157218)
5 years ago (2015-12-18 00:41:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534623002/40001
5 years ago (2015-12-18 00:54:36 UTC) #20
Ken Russell (switch to Gerrit)
On 2015/12/18 00:41:30, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-18 00:58:36 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-18 01:26:27 UTC) #22
commit-bot: I haz the power
5 years ago (2015-12-18 01:27:55 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d745f1ab5e11fab3fabdd47626ac4b39e9d42c2f
Cr-Commit-Position: refs/heads/master@{#365965}

Powered by Google App Engine
This is Rietveld 408576698