src/compiler/ia32/instruction-scheduler-ia32.cc - Issue 1534593004: [turbofan] Pass type information of arguments to EmitPrepareArguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ia32/instruction-scheduler-ia32.cc

Issue 1534593004: [turbofan] Pass type information of arguments to EmitPrepareArguments. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/compiler/ia32/instruction-codes-ia32.h ('k') | src/compiler/ia32/instruction-selector-ia32.cc » ('j') | src/compiler/ia32/instruction-selector-ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/compiler/ia32/instruction-scheduler-ia32.cc

diff --git a/src/compiler/ia32/instruction-scheduler-ia32.cc b/src/compiler/ia32/instruction-scheduler-ia32.cc

index 27c1e389a6b587c7e44eebcaa2aa85a0daaed5ad..f79962fe7c2169104c7d2164c497bcb3bb9a982b 100644

--- a/src/compiler/ia32/instruction-scheduler-ia32.cc

+++ b/src/compiler/ia32/instruction-scheduler-ia32.cc

@@ -108,6 +108,7 @@ int InstructionScheduler::GetTargetInstructionFlags(

return kIsLoadOperation;

case kIA32Push:

+ case kIA32PushDouble:

case kIA32Poke:

return kHasSideEffect;