[turbofan] Pass type information of arguments to EmitPrepareArguments.

[turbofan] Pass type information of arguments to EmitPrepareArguments.

On ia32 the code which pushes parameters on the stack depends on the
types of the parameters which are to be pushed. I provide this type
information now by not only passing parameter nodes to
EmitPrepareArguments, but also the index in the call descriptor which
belongs to the parameter nodes.

This type information will also be necessary if we want to use the
PokePair instruction on arm64 again.

R=bradnelson@chromium.org, bmeurer@chromium.org

Committed: https://crrev.com/c0c8c756de1a90f0f558f69a234b4eb581a0db3c
Cr-Commit-Position: refs/heads/master@{#32982}

[bradn, 2015-12-17 13:58:35]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2015-12-17 13:58:36]

https://codereview.chromium.org/1534593004/diff/1/src/compiler/ia32/instructi...
File src/compiler/ia32/instruction-selector-ia32.cc (right):

https://codereview.chromium.org/1534593004/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-selector-ia32.cc:939: Emit(kIA32PushDouble,
g.NoOutput(), value);
Wait why are float32 a double value on ia32?

[ahaas, 2015-12-17 14:23:45]

ahaas@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2015-12-17 14:33:49]

https://codereview.chromium.org/1534593004/diff/1/src/compiler/ia32/instructi...
File src/compiler/ia32/instruction-selector-ia32.cc (right):

https://codereview.chromium.org/1534593004/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-selector-ia32.cc:935: if
(descriptor->GetInputType(input.parameter_index()) ==
How about using IsFloatingPoint(...)?

https://codereview.chromium.org/1534593004/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-selector-ia32.cc:937:
descriptor->GetInputType(input.parameter_index()) ==
I am wondering why PushParameter contains the index when all you need is the
type?

[ahaas, 2015-12-18 10:16:46]

https://codereview.chromium.org/1534593004/diff/1/src/compiler/ia32/instructi...
File src/compiler/ia32/instruction-selector-ia32.cc (right):

https://codereview.chromium.org/1534593004/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-selector-ia32.cc:935: if
(descriptor->GetInputType(input.parameter_index()) ==
On 2015/12/17 at 14:33:49, Jarin wrote:
> How about using IsFloatingPoint(...)?

I generate different code for float32 and float64 now, and therefore I cannot
use IsFloatingPoint anymore.

https://codereview.chromium.org/1534593004/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-selector-ia32.cc:937:
descriptor->GetInputType(input.parameter_index()) ==
On 2015/12/17 at 14:33:49, Jarin wrote:
> I am wondering why PushParameter contains the index when all you need is the
type?

Done. PushParameter now only contains the type of the parameter, not the index
anymore.

https://codereview.chromium.org/1534593004/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-selector-ia32.cc:939: Emit(kIA32PushDouble,
g.NoOutput(), value);
On 2015/12/17 at 13:58:36, bradn wrote:
> Wait why are float32 a double value on ia32?

Float32 and Float64 are handled differently now.

[Jarin, 2015-12-21 10:04:19]

lgtm

[ahaas, 2015-12-21 10:12:44]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2015-12-21 10:12:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534593004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534593004/20001

[commit-bot: I haz the power, 2015-12-21 10:32:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-21 10:33:06]

Description was changed from

==========
[turbofan] Pass type information of arguments to EmitPrepareArguments.

On ia32 the code which pushes parameters on the stack depends on the
types of the parameters which are to be pushed. I provide this type
information now by not only passing parameter nodes to
EmitPrepareArguments, but also the index in the call descriptor which
belongs to the parameter nodes.

This type information will also be necessary if we want to use the
PokePair instruction on arm64 again.

R=bradnelson@chromium.org, bmeurer@chromium.org
==========

to

==========
[turbofan] Pass type information of arguments to EmitPrepareArguments.

On ia32 the code which pushes parameters on the stack depends on the
types of the parameters which are to be pushed. I provide this type
information now by not only passing parameter nodes to
EmitPrepareArguments, but also the index in the call descriptor which
belongs to the parameter nodes.

This type information will also be necessary if we want to use the
PokePair instruction on arm64 again.

R=bradnelson@chromium.org, bmeurer@chromium.org

Committed: https://crrev.com/c0c8c756de1a90f0f558f69a234b4eb581a0db3c
Cr-Commit-Position: refs/heads/master@{#32982}
==========

[commit-bot: I haz the power, 2015-12-21 10:33:07]

Patchset 2 (id:??) landed as
https://crrev.com/c0c8c756de1a90f0f558f69a234b4eb581a0db3c
Cr-Commit-Position: refs/heads/master@{#32982}