chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc - Issue 1534583002: Migrate Local Discovery from net::IPAddressNumber to net::IPAddress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

Issue 1534583002: Migrate Local Discovery from net::IPAddressNumber to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix builders Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/service_discovery_client_unittest.cc ('k') | chrome/tools/service_discovery_sniffer/service_discovery_sniffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

diff --git a/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc b/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

index 0675ab36191ef11d35001a5635d988153adbced4..ff4743eadab887fad399fe5acf7fb4bdd949abf6 100644

--- a/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

+++ b/chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc

@@ -189,10 +189,8 @@ class PrivetDeviceListerTest : public testing::Test {

service_description_.metadata = example_attrs_;

service_description_.last_seen = base::Time() +

base::TimeDelta::FromSeconds(5);

- service_description_.ip_address.push_back(1);

- service_description_.ip_address.push_back(2);

- service_description_.ip_address.push_back(3);

- service_description_.ip_address.push_back(4);

+ ASSERT_TRUE(net::IPAddress::FromIPLiteral(

+ "1.2.3.4", &service_description_.ip_address));

}

protected: