chrome/browser/local_discovery/service_discovery_client_impl.h - Issue 1534583002: Migrate Local Discovery from net::IPAddressNumber to net::IPAddress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/service_discovery_client_impl.h

Issue 1534583002: Migrate Local Discovery from net::IPAddressNumber to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: V2 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/mdns/dns_sd_device_lister.cc ('K') | « chrome/browser/local_discovery/service_discovery_client.h ('k') | chrome/browser/local_discovery/service_discovery_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/service_discovery_client_impl.h

diff --git a/chrome/browser/local_discovery/service_discovery_client_impl.h b/chrome/browser/local_discovery/service_discovery_client_impl.h

index c8118a3c369fc97d902f59e49384c1bf595e80c1..3f7acdb98934c0a3534301a20cd712abef39bd86 100644

--- a/chrome/browser/local_discovery/service_discovery_client_impl.h

+++ b/chrome/browser/local_discovery/service_discovery_client_impl.h

@@ -197,8 +197,7 @@ class ServiceResolverImpl

const net::RecordParsed* record) const;

// Convert an A record to an IP address.

- const net::IPAddressNumber& RecordToIPAddress(

- const net::RecordParsed* record) const;

+ const net::IPAddress RecordToIPAddress(const net::RecordParsed* record) const;

eroman 2016/01/28 20:08:44 Instead of "const net::IPAddress" write simply "ne

martijnc 2016/01/29 18:33:45 Done. I'll revisit this when net::ARecordRdata is

// Convert an MDns status to a service discovery status.

RequestStatus MDnsStatusToRequestStatus(

@@ -259,8 +258,8 @@ class LocalDomainResolverImpl : public LocalDomainResolver {

net::MDnsClient* mdns_client_;

- net::IPAddressNumber address_ipv4_;

- net::IPAddressNumber address_ipv6_;

+ net::IPAddress address_ipv4_;

+ net::IPAddress address_ipv6_;

base::CancelableCallback<void()> timeout_callback_;