Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: net/base/ip_endpoint.h

Issue 1534583002: Migrate Local Discovery from net::IPAddressNumber to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/ip_endpoint.h
diff --git a/net/base/ip_endpoint.h b/net/base/ip_endpoint.h
index 575040f2a30c6f42400eaf53cad76993086ec016..ea7b3835822d499f59f7c8377af9b32833db4ccd 100644
--- a/net/base/ip_endpoint.h
+++ b/net/base/ip_endpoint.h
@@ -19,6 +19,8 @@ struct sockaddr;
namespace net {
+class IPAddress;
+
// An IPEndPoint represents the address of a transport endpoint:
// * IP address (either v4 or v6)
// * Port
@@ -27,6 +29,7 @@ class NET_EXPORT IPEndPoint {
IPEndPoint();
~IPEndPoint();
IPEndPoint(const IPAddressNumber& address, uint16_t port);
+ IPEndPoint(const IPAddress& address, uint16_t port);
tfarina 2015/12/21 23:13:36 Eric, is it a good idea to make this change separa
eroman 2015/12/21 23:25:04 Yes. In fact a number of my recommendations make s
tfarina 2015/12/22 00:20:34 I have made it separately. https://codereview.chr
IPEndPoint(const IPEndPoint& endpoint);
const IPAddressNumber& address() const { return address_; }

Powered by Google App Engine
This is Rietveld 408576698