Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: third_party/WebKit/public/platform/WebMediaRecorderHandler.h

Issue 1534553003: MediaRecorder: correct MIME type parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tommi@s comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebMediaRecorderHandler.h
diff --git a/third_party/WebKit/public/platform/WebMediaRecorderHandler.h b/third_party/WebKit/public/platform/WebMediaRecorderHandler.h
index 309f1da0af96f9c1b0ef237be3fb2655252e7256..2bb32a9b7d6b002a73e8588a275d42c1b75d192d 100644
--- a/third_party/WebKit/public/platform/WebMediaRecorderHandler.h
+++ b/third_party/WebKit/public/platform/WebMediaRecorderHandler.h
@@ -17,21 +17,21 @@ class WebString;
class BLINK_PLATFORM_EXPORT WebMediaRecorderHandler {
public:
virtual ~WebMediaRecorderHandler() = default;
- virtual bool initialize(WebMediaRecorderHandlerClient* client, const WebMediaStream& stream, const WebString& mimeType) { return false; }
+ virtual bool initialize(WebMediaRecorderHandlerClient* client, const WebMediaStream& stream, const WebString& type, const WebString& codecs) { return false; }
virtual bool start() { return false; }
virtual bool start(int timeslice) { return false; }
virtual void stop() {}
virtual void pause() {}
virtual void resume() {}
- // MediaRecorder API canRecordMimeType() is a tristate in which the returned
- // value 'probably' means that "the user agent is confident that mimeType
- // represents a type that it can record" [1], but a number of reasons might
- // prevent a firm answer at this stage, so a boolean is a better option,
- // because "Implementors are encouraged to return "maybe" unless the type
- // can be confidently established as being supported or not." [1].
+ // MediaRecorder API isTypeSupported(), which boils down to
+ // canSupportMimeType() [1] "If true is returned from this method, it only
+ // indicates that the MediaRecorder implementation is capable of recording
+ // Blob objects for the specified MIME type. Recording may still fail if
+ // sufficient resources are not available to support the concrete media
+ // encoding."
// [1] https://w3c.github.io/mediacapture-record/MediaRecorder.html#methods
- virtual bool canSupportMimeType(const WebString& mimeType) { return false; }
+ virtual bool canSupportMimeType(const WebString& type, const WebString& codecs) { return false; }
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698