Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-isTypeSupported.html

Issue 1534553003: MediaRecorder: correct MIME type parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tommi@s comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-isTypeSupported.html
diff --git a/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-isTypeSupported.html b/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-isTypeSupported.html
index 49f2253c365f452316ca6d1f407fd70e5c7a63a3..796935d536e2d5a33ecff9b4570db77b7dc02cdd 100644
--- a/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-isTypeSupported.html
+++ b/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-isTypeSupported.html
@@ -2,28 +2,39 @@
<script src=../../resources/testharness.js></script>
<script src=../../resources/testharnessreport.js></script>
<script>
-// Check the Video formats that should be recordable and one that should not be.
-// Supported formats return "maybe". Same for Audio.
+// Check some video MIME types that should be recordable and a few that should
+// not be. Supported MIME types return true. Same for Audio.
// https://w3c.github.io/mediacapture-record/MediaRecorder.html#methods
test(function() {
assert_false(MediaRecorder.isTypeSupported("video/invalid"));
-}, 'check MediaRecorder.isTypeSupported() with video/invalid');
+ assert_false(MediaRecorder.isTypeSupported("video/mpeg4"));
+ assert_false(MediaRecorder.isTypeSupported("video/webm;codecs=daala"));
+}, 'check MediaRecorder.isTypeSupported() with invalid video MIME types');
test(function() {
- assert_true(MediaRecorder.isTypeSupported("video/vp8"));
-}, 'check MediaRecorder.isTypeSupported() with video/vp8');
-
-test(function() {
- assert_true(MediaRecorder.isTypeSupported("video/vp9"));
-}, 'check MediaRecorder.isTypeSupported() with video/vp9');
+ assert_true(MediaRecorder.isTypeSupported("video/webm"));
+ assert_true(MediaRecorder.isTypeSupported("video/webm;codecs=vp8"));
+ assert_true(MediaRecorder.isTypeSupported("video/webm;codecs=vp9"));
+ assert_true(MediaRecorder.isTypeSupported("video/webm;codecs=vp8.0"));
+ assert_true(MediaRecorder.isTypeSupported("video/webm;codecs=vp9.0"));
+ // "video/webm" supports audio codec specification, see
+ // http://www.webmproject.org/docs/container/
+ assert_true(MediaRecorder.isTypeSupported("video/webm;codecs=vp8,opus"));
+ assert_true(MediaRecorder.isTypeSupported("video/WEBM;codecs=VP8,OPUS"));
+ assert_true(MediaRecorder.isTypeSupported("video/webm;codecs=vp9,opus"));
+ assert_true(MediaRecorder.isTypeSupported("video/webm;codecs=vp8,vp9,opus"));
+}, 'check MediaRecorder.isTypeSupported() with valid video MIME types');
test(function() {
assert_false(MediaRecorder.isTypeSupported("audio/invalid"));
-}, 'check MediaRecorder.isTypeSupported() with audio/invalid');
+ assert_false(MediaRecorder.isTypeSupported("audio/ogg"));
+ assert_false(MediaRecorder.isTypeSupported("audio/webm;codecs=vorbis"));
+}, 'check MediaRecorder.isTypeSupported() with invalid audio MIME types');
test(function() {
- assert_true(MediaRecorder.isTypeSupported("audio/opus"));
-}, 'check MediaRecorder.isTypeSupported() with audio/opus');
+ assert_true(MediaRecorder.isTypeSupported("audio/webm"));
+ assert_true(MediaRecorder.isTypeSupported("audio/webm;codecs=opus"));
+}, 'check MediaRecorder.isTypeSupported() with valid audio MIME types');
</script>
« no previous file with comments | « content/test/data/media/mediarecorder_test.html ('k') | third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698