content/renderer/media/media_recorder_handler.h - Issue 1534553003: MediaRecorder: correct MIME type parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_recorder_handler.h

Issue 1534553003: MediaRecorder: correct MIME type parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated content_unittests, updated vp9 handling Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/media_recorder_handler.h

diff --git a/content/renderer/media/media_recorder_handler.h b/content/renderer/media/media_recorder_handler.h

index 05a215d8f5292f16cfcd1045b76cabf4528b3c6e..6b11185f5f3c689e572acd2797d0e3502f49105f 100644

--- a/content/renderer/media/media_recorder_handler.h

+++ b/content/renderer/media/media_recorder_handler.h

@@ -47,10 +47,12 @@ class CONTENT_EXPORT MediaRecorderHandler final

~MediaRecorderHandler() override;

// blink::WebMediaRecorderHandler.

- bool canSupportMimeType(const blink::WebString& mimeType) override;

+ bool canSupportMimeType(const blink::WebString& type,

+ const blink::WebString& codecs) override;

bool initialize(blink::WebMediaRecorderHandlerClient* client,

const blink::WebMediaStream& media_stream,

- const blink::WebString& mimeType) override;

+ const blink::WebString& type,

+ const blink::WebString& codecs) override;

bool start() override;

bool start(int timeslice) override;

void stop() override;