Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1534543003: X87: [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. port 5bd4832492e66b79b19a45653abc68bef3cd6cb4 (r32929) original commit message: Introduce a new Apply builtin that forms a correct and optimizable foundation for the Function.prototype.apply, Reflect.construct and Reflect.apply builtins (which properly does the PrepareForTailCall as required by the ES2015 spec). The new Apply builtin avoids going to the runtime if it is safe to just access the backing store elements of the argArray, i.e. if you pass a JSArray with no holes, or an unmapped, unmodified sloppy or strict arguments object. mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>; BUG= Committed: https://crrev.com/bea8d4c9109fcf6cadc532b6ae232716d5048259 Cr-Commit-Position: refs/heads/master@{#32960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -170 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +328 lines, -170 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
5 years ago (2015-12-17 15:02:15 UTC) #2
zhengxing.li
5 years ago (2015-12-17 15:02:24 UTC) #3
Weiliang
lgtm
5 years ago (2015-12-18 01:12:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534543003/1
5 years ago (2015-12-18 01:13:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 01:37:11 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-18 01:38:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bea8d4c9109fcf6cadc532b6ae232716d5048259
Cr-Commit-Position: refs/heads/master@{#32960}

Powered by Google App Engine
This is Rietveld 408576698