Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1534523002: Compress Observatory assets (Closed)

Created:
5 years ago by Cutch
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compress Observatory assets - Gzip the Observatory assets tar file before encoding into the C++ source file. Shrinks observatory_assets.cc from ~21MB to ~4MB. Fixes #25276 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/cc0f297703c43527a999a99075a3174765aa7590

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -6 lines) Patch
M runtime/bin/bin.gypi View 5 chunks +5 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 2 chunks +77 lines, -3 lines 0 comments Download
M runtime/bin/vmservice_dartium.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/vmservice_dartium.cc View 1 2 chunks +63 lines, -0 lines 0 comments Download
M runtime/tools/create_archive.py View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Cutch
5 years ago (2015-12-16 18:38:28 UTC) #4
rmacnak
lgtm
5 years ago (2015-12-16 19:09:17 UTC) #6
Cutch
5 years ago (2015-12-16 20:36:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cc0f297703c43527a999a99075a3174765aa7590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698