Create the PruneCrashReportsThread in the handler.

Create the PruneCrashReportsThread in the handler.

This will prune the database on a daily basis, in accordance with the specified
condition.

BUG=crashpad:22
R=mark@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/18a294130552dc827339f0ca57794177cee2b552

[Robert Sesek, 2016-01-04 23:10:06]

Patchset #1 (id:1) has been deleted

[Robert Sesek, 2016-01-04 23:10:10]

Patchset #1 (id:20001) has been deleted

[Robert Sesek, 2016-01-04 23:11:12]

Patchset #1 (id:40001) has been deleted

[Robert Sesek, 2016-01-04 23:11:59]

Description was changed from

==========
NOT FOR REVIEW

Prune thread WIP.
==========

to

==========
Create the PruneCrashReportsThread in the handler.

This will prune the database on a daily basis, in accordance with the specified
condition.

BUG=crashpad:22
R=mark@chromium.org
==========

[Robert Sesek, 2016-01-04 23:12:12]

Description was changed from

==========
Create the PruneCrashReportsThread in the handler.

This will prune the database on a daily basis, in accordance with the specified
condition.

BUG=crashpad:22
R=mark@chromium.org
==========

to

==========
Create the PruneCrashReportsThread in the handler.

This will prune the database on a daily basis, in accordance with the specified
condition.

BUG=crashpad:22
R=mark@chromium.org
==========

[Robert Sesek, 2016-01-04 23:12:12]

rsesek@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2016-01-05 20:05:06]

LGTM

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
File handler/prune_crash_reports_thread.cc (right):

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
handler/prune_crash_reports_thread.cc:17: #include "base/logging.h"
Not used.

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
handler/prune_crash_reports_thread.cc:18: #include
"client/crash_report_database.h"
Not used (the forward declaration in the header is enough for the implementation
too).

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
File handler/prune_crash_reports_thread.h (right):

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
handler/prune_crash_reports_thread.h:36: //! \param[in] database The database to
upload crash reports from.
Not about uploading at all in this file.

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
handler/prune_crash_reports_thread.h:69:
DISALLOW_COPY_AND_ASSIGN(PruneCrashReportThread);
basictypes.h for this, and when I get rid of basictypes.h later, I’ll move it to
macros.h with the rest of the files.

[Robert Sesek, 2016-01-05 20:08:54]

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
File handler/prune_crash_reports_thread.cc (right):

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
handler/prune_crash_reports_thread.cc:17: #include "base/logging.h"
On 2016/01/05 20:05:06, Mark Mentovai wrote:
> Not used.

Done.

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
handler/prune_crash_reports_thread.cc:18: #include
"client/crash_report_database.h"
On 2016/01/05 20:05:06, Mark Mentovai wrote:
> Not used (the forward declaration in the header is enough for the
implementation
> too).

Done.

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
File handler/prune_crash_reports_thread.h (right):

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
handler/prune_crash_reports_thread.h:36: //! \param[in] database The database to
upload crash reports from.
On 2016/01/05 20:05:06, Mark Mentovai wrote:
> Not about uploading at all in this file.

Done.

https://codereview.chromium.org/1534503002/diff/60001/handler/prune_crash_rep...
handler/prune_crash_reports_thread.h:69:
DISALLOW_COPY_AND_ASSIGN(PruneCrashReportThread);
On 2016/01/05 20:05:06, Mark Mentovai wrote:
> basictypes.h for this, and when I get rid of basictypes.h later, I’ll move it
to
> macros.h with the rest of the files.

Done.

[Robert Sesek, 2016-01-05 20:09:02]

Description was changed from

==========
Create the PruneCrashReportsThread in the handler.

This will prune the database on a daily basis, in accordance with the specified
condition.

BUG=crashpad:22
R=mark@chromium.org
==========

to

==========
Create the PruneCrashReportsThread in the handler.

This will prune the database on a daily basis, in accordance with the specified
condition.

BUG=crashpad:22
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/crashpad/crashpad/+/18a294130552dc827339f0c...
==========

[Robert Sesek, 2016-01-05 20:09:03]

Committed patchset #2 (id:80001) manually as
18a294130552dc827339f0ca57794177cee2b552 (presubmit successful).