Bugfix: Make sure not to overwrite the empty optimized code map root.

Bugfix: Make sure not to overwrite the empty optimized code map root.

BUG=chromium:568765
LOG=N
R=jkummerow@chromium.org

Committed: https://crrev.com/6540e736f34c8855526747acbd7d46d37164adbd
Cr-Commit-Position: refs/heads/master@{#32910}

[mvstanton, 2015-12-16 15:02:38]

Hi Jakob,
You posted a call stack that showed the source of the bug, so thank you! For
that...could you review my fix? :).
--Mike

[mvstanton, 2015-12-16 15:09:55]

Description was changed from

==========
Bugfix: Make sure not to overwrite the empty optimized code map root.

BUG=568765
LOG=N
R=jkummerow@chromium.org
==========

to

==========
Bugfix: Make sure not to overwrite the empty optimized code map root.

BUG=chromium:568765
LOG=N
R=jkummerow@chromium.org
==========

[Jakob Kummerow, 2015-12-16 15:24:20]

LGTM. You may need to add your test to the Ignition skip list.

https://codereview.chromium.org/1534453002/diff/20001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-568765.js (right):

https://codereview.chromium.org/1534453002/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-568765.js:92: for (var __v_20 = 0; __v_20 <= 20;
__v_20++) {
Does the test still trigger the issue without this empty loop?

[mvstanton, 2015-12-16 15:52:25]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-12-16 15:52:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1534453002/#ps40001
(title: "altered loop, removed for ignition.")

[commit-bot: I haz the power, 2015-12-16 15:52:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534453002/40001

[mvstanton, 2015-12-16 15:53:18]

Thanks Jakob!
Added to the skip list, removed the loop.
--Mike

https://codereview.chromium.org/1534453002/diff/20001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-568765.js (right):

https://codereview.chromium.org/1534453002/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-568765.js:92: for (var __v_20 = 0; __v_20 <= 20;
__v_20++) {
On 2015/12/16 15:24:20, Jakob wrote:
> Does the test still trigger the issue without this empty loop?

as long as I defined __v_20 and __v_9 it's okay, so yep, I removed the loop.

[commit-bot: I haz the power, 2015-12-16 16:27:58]

Description was changed from

==========
Bugfix: Make sure not to overwrite the empty optimized code map root.

BUG=chromium:568765
LOG=N
R=jkummerow@chromium.org
==========

to

==========
Bugfix: Make sure not to overwrite the empty optimized code map root.

BUG=chromium:568765
LOG=N
R=jkummerow@chromium.org
==========

[commit-bot: I haz the power, 2015-12-16 16:27:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-16 16:28:08]

Description was changed from

==========
Bugfix: Make sure not to overwrite the empty optimized code map root.

BUG=chromium:568765
LOG=N
R=jkummerow@chromium.org
==========

to

==========
Bugfix: Make sure not to overwrite the empty optimized code map root.

BUG=chromium:568765
LOG=N
R=jkummerow@chromium.org

Committed: https://crrev.com/6540e736f34c8855526747acbd7d46d37164adbd
Cr-Commit-Position: refs/heads/master@{#32910}
==========

[commit-bot: I haz the power, 2015-12-16 16:28:08]

Patchset 3 (id:??) landed as
https://crrev.com/6540e736f34c8855526747acbd7d46d37164adbd
Cr-Commit-Position: refs/heads/master@{#32910}