Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1534443004: Adjust assert in evaluate for activations. (Closed)

Created:
5 years ago by rmacnak
Modified:
5 years ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust assert in evaluate for activations. I don't believe this fixes the referenced bug, but it is related. BUG=http://dartbug.com/25210 R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/ceff9d33d7e1612c220ef9d4e135fe54da930e26

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/vm/debugger.cc View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
rmacnak
5 years ago (2015-12-16 20:43:58 UTC) #2
turnidge
https://codereview.chromium.org/1534443004/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/1534443004/diff/1/runtime/vm/debugger.cc#newcode1058 runtime/vm/debugger.cc:1058: if (!(receiver.IsInstance() || receiver.IsNull())) { Should you be checkout ...
5 years ago (2015-12-17 19:42:25 UTC) #3
turnidge
lgtm We talked offline.
5 years ago (2015-12-17 20:25:45 UTC) #4
rmacnak
5 years ago (2015-12-17 22:40:16 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ceff9d33d7e1612c220ef9d4e135fe54da930e26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698