src/core/SkPicturePlayback.cpp - Issue 1534443003: remove drawSprite from canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPicturePlayback.cpp

Issue 1534443003: remove drawSprite from canvas (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: really tired of unused variable warnings Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPicturePlayback.cpp

diff --git a/src/core/SkPicturePlayback.cpp b/src/core/SkPicturePlayback.cpp

index b994071cbb4b0ad9d021aaf41524a0b7f2890c03..9b27a3d1e91067b2368a1b664dc0430c1799a183 100644

--- a/src/core/SkPicturePlayback.cpp

+++ b/src/core/SkPicturePlayback.cpp

@@ -368,11 +368,11 @@ void SkPicturePlayback::handleOp(SkReader32* reader,

canvas->drawRRect(rrect, paint);

} break;

case DRAW_SPRITE: {

- const SkPaint* paint = fPictureData->getPaint(reader);

- const SkBitmap bitmap = shallow_copy(fPictureData->getBitmap(reader));

- int left = reader->readInt();

- int top = reader->readInt();

- canvas->drawSprite(bitmap, left, top, paint);

+ /* const SkPaint* paint = */ fPictureData->getPaint(reader);

+ /* const SkBitmap bitmap = */ shallow_copy(fPictureData->getBitmap(reader));

+ /* int left = */ reader->readInt();

+ /* int top = */ reader->readInt();

+ // drawSprite removed dec-2015

f(malita) 2015/12/16 15:34:17 Could we emulate drawSprite using setMatrix + draw

} break;

case DRAW_TEXT: {

const SkPaint& paint = *fPictureData->getPaint(reader);

« no previous file with comments | « src/core/SkCanvas.cpp ('k') | src/core/SkPictureRecord.h » ('j') | no next file with comments »