third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp - Issue 1534323003: DevTools: [CSS] do not treat random css comments as disabled properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

Issue 1534323003: DevTools: [CSS] do not treat random css comments as disabled properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-formatting-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp b/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

index 1e19d753e365874cf73706956857539fc91ed593..968f4629ada3f14740de9f0b823862f6e1660ef9 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

@@ -296,7 +296,8 @@ void StyleSheetHandler::observeComment(unsigned startOffset, unsigned endOffset)

if (commentPropertyData.size() != 1)

return;

CSSPropertySourceData& propertyData = commentPropertyData.at(0);

- if (propertyData.range.length() != commentText.length())

+ bool parsedOk = propertyData.parsedOk || propertyData.name.startsWith("-moz-") || propertyData.name.startsWith("-o-") || propertyData.name.startsWith("-webkit-") || propertyData.name.startsWith("-ms-");

+ if (!parsedOk || propertyData.range.length() != commentText.length())

return;

m_currentRuleDataStack.last()->styleSourceData->propertyData.append(