DevTools: [CSS] do not treat random css comments as disabled properties

DevTools: [CSS] do not treat random css comments as disabled properties

The patch starts treating css comments as CSS properties if the parsed
property name resembles a valid property name.

BUG=568017
R=pfeldman

Committed: https://crrev.com/5a3d61f3091190578c081d576dba415d12ded016
Cr-Commit-Position: refs/heads/master@{#369365}

[lushnikov, 2015-12-19 00:25:55]

ptal

[pfeldman, 2016-01-04 21:27:01]

https://codereview.chromium.org/1534323003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://codereview.chromium.org/1534323003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:1475: return
CSS.supports(propertyName, "initial") || propertyName.startsWith("-moz-") ||
propertyName.startsWith("-o-") || propertyName.startsWith("-webkit-") ||
propertyName.startsWith("-ms-");
You should either query the target (generated) css property set or whitelist all
of the supported ones (get them from the cm highlight).

[lushnikov, 2016-01-11 23:52:11]

https://codereview.chromium.org/1534323003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://codereview.chromium.org/1534323003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:1475: return
CSS.supports(propertyName, "initial") || propertyName.startsWith("-moz-") ||
propertyName.startsWith("-o-") || propertyName.startsWith("-webkit-") ||
propertyName.startsWith("-ms-");
On 2016/01/04 21:27:01, pfeldman wrote:
> You should either query the target (generated) css property set or whitelist
all
> of the supported ones (get them from the cm highlight).

How are your suggestions better than this?

[lushnikov, 2016-01-13 00:56:06]

Addressed your comments. Please, take another look.

[pfeldman, 2016-01-13 02:26:06]

lgtm

[lushnikov, 2016-01-13 02:36:13]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-01-13 02:37:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534323003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534323003/20001

[commit-bot: I haz the power, 2016-01-13 02:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 02:41:01]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-01-13 20:48:14]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-01-13 20:48:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1534323003/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-01-13 20:49:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534323003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534323003/40001

[commit-bot: I haz the power, 2016-01-13 23:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 23:55:19]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[lushnikov, 2016-01-14 00:24:19]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-01-14 00:26:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534323003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534323003/40001

[commit-bot: I haz the power, 2016-01-14 02:39:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 02:39:04]

Exceeded global retry quota

[lushnikov, 2016-01-14 07:42:23]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-01-14 07:42:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534323003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534323003/40001

[commit-bot: I haz the power, 2016-01-14 07:46:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-14 07:48:33]

Description was changed from

==========
DevTools: [CSS] do not treat random css comments as disabled properties

The patch starts treating css comments as CSS properties if the parsed
property name resembles a valid property name.

BUG=568017
R=pfeldman
==========

to

==========
DevTools: [CSS] do not treat random css comments as disabled properties

The patch starts treating css comments as CSS properties if the parsed
property name resembles a valid property name.

BUG=568017
R=pfeldman

Committed: https://crrev.com/5a3d61f3091190578c081d576dba415d12ded016
Cr-Commit-Position: refs/heads/master@{#369365}
==========

[commit-bot: I haz the power, 2016-01-14 07:48:34]

Patchset 3 (id:??) landed as
https://crrev.com/5a3d61f3091190578c081d576dba415d12ded016
Cr-Commit-Position: refs/heads/master@{#369365}