Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1534313002: tools/gn: another round of fixes to keep bootstrap working (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, tfarina, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: another round of fixes to keep bootstrap working This patch includes metrics_hashes.cc and md5.cc to the base's sources list to fix the undefined errors as below: base/metrics/histogram.o: In function `base::Histogram::Histogram(std::string const&, int, int, base::BucketRanges const*)': histogram.cc:(.text+0xfc0): undefined reference to `base::HashMetricName(std::string const&)' BUG=569821 TEST=./tools/gn/bootstrap/bootstrap.py TBR=brettw@chromium.org Committed: https://crrev.com/9608e1467c41eaabab78e68da96a00f475aa25d6 Cr-Commit-Position: refs/heads/master@{#366194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tfarina
TBRing...
5 years ago (2015-12-18 22:44:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534313002/1
5 years ago (2015-12-18 22:44:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 23:10:18 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9608e1467c41eaabab78e68da96a00f475aa25d6 Cr-Commit-Position: refs/heads/master@{#366194}
5 years ago (2015-12-18 23:11:18 UTC) #6
Dirk Pranke
5 years ago (2015-12-19 19:53:01 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698