Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1534283002: Temporarily increase verbosity of Chromoting test-driver execution logs, to get more info on random… (Closed)

Created:
5 years ago by anandc1
Modified:
5 years ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily increase verbosity of Chromoting test-driver execution logs, to get more info on random Signaling errors. With this change, test log-size increases from ~32K to ~522K; we hope to revert to the previous less-verbose level soon. BUG=570840 Committed: https://crrev.com/ac6ae81c0a36cea7e2899afb5be58c808510a791 Cr-Commit-Position: refs/heads/master@{#366190}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Increase verbosity of Chromium code logging, leave remoting unchanged for now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing/chromoting/chromoting_test_driver_commands_linux.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
anandc1
Hi Joe, PTAL. Thanks.
5 years ago (2015-12-18 21:26:21 UTC) #4
joedow
https://codereview.chromium.org/1534283002/diff/1/testing/chromoting/chromoting_test_driver_commands_linux.txt File testing/chromoting/chromoting_test_driver_commands_linux.txt (right): https://codereview.chromium.org/1534283002/diff/1/testing/chromoting/chromoting_test_driver_commands_linux.txt#newcode1 testing/chromoting/chromoting_test_driver_commands_linux.txt:1: #PROD_DIR#/chromoting_test_driver --username=chromoting.swarming@gmail.com --refresh-token-path=../../remoting/tools/internal/refresh_tokens.json --hostname=chromoting-test-driver-host --verbosity=3 --gtest_filter=ChromotingTestFixture.TestMeasurePinBasedAuthentication --pin=123456 This will ...
5 years ago (2015-12-18 21:31:53 UTC) #5
anandc1
Thanks for catching Joe. PTAL at patch-set 2. https://codereview.chromium.org/1534283002/diff/1/testing/chromoting/chromoting_test_driver_commands_linux.txt File testing/chromoting/chromoting_test_driver_commands_linux.txt (right): https://codereview.chromium.org/1534283002/diff/1/testing/chromoting/chromoting_test_driver_commands_linux.txt#newcode1 testing/chromoting/chromoting_test_driver_commands_linux.txt:1: #PROD_DIR#/chromoting_test_driver ...
5 years ago (2015-12-18 21:40:15 UTC) #6
joedow
lgtm
5 years ago (2015-12-18 22:06:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534283002/20001
5 years ago (2015-12-18 22:19:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-18 22:56:11 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-18 22:57:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac6ae81c0a36cea7e2899afb5be58c808510a791
Cr-Commit-Position: refs/heads/master@{#366190}

Powered by Google App Engine
This is Rietveld 408576698