Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: media/base/android/media_player_bridge.cc

Issue 1534273002: Switch to standard integer types in media/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_player_bridge.cc
diff --git a/media/base/android/media_player_bridge.cc b/media/base/android/media_player_bridge.cc
index 246bd7c0e90cde2b7ba68789ebfcbf885768a919..e0cdb6699681775a9b6da7bf37ac680357b54cd7 100644
--- a/media/base/android/media_player_bridge.cc
+++ b/media/base/android/media_player_bridge.cc
@@ -7,7 +7,6 @@
#include "base/android/context_utils.h"
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
-#include "base/basictypes.h"
#include "base/logging.h"
#include "base/strings/string_util.h"
#include "jni/MediaPlayerBridge_jni.h"
@@ -144,8 +143,8 @@ void MediaPlayerBridge::SetDataSource(const std::string& url) {
CHECK(env);
int fd;
- int64 offset;
- int64 size;
+ int64_t offset;
+ int64_t size;
if (InterceptMediaUrl(url, &fd, &offset, &size)) {
if (!Java_MediaPlayerBridge_setDataSourceFromFd(
env, j_media_player_bridge_.obj(), fd, offset, size)) {
@@ -186,8 +185,10 @@ void MediaPlayerBridge::SetDataSource(const std::string& url) {
OnMediaError(MEDIA_ERROR_FORMAT);
}
-bool MediaPlayerBridge::InterceptMediaUrl(
- const std::string& url, int* fd, int64* offset, int64* size) {
+bool MediaPlayerBridge::InterceptMediaUrl(const std::string& url,
+ int* fd,
+ int64_t* offset,
+ int64_t* size) {
// Sentinel value to check whether the output arguments have been set.
const int kUnsetValue = -1;
@@ -246,8 +247,8 @@ void MediaPlayerBridge::ExtractMediaMetadata(const std::string& url) {
}
int fd;
- int64 offset;
- int64 size;
+ int64_t offset;
+ int64_t size;
if (InterceptMediaUrl(url, &fd, &offset, &size)) {
manager()->GetMediaResourceGetter()->ExtractMediaMetadata(
fd, offset, size,

Powered by Google App Engine
This is Rietveld 408576698