Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: media/cast/sender/congestion_control.cc

Issue 1534273002: Switch to standard integer types in media/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/sender/congestion_control.cc
diff --git a/media/cast/sender/congestion_control.cc b/media/cast/sender/congestion_control.cc
index 0c3705646d96128ef8bae70173a21711b0b43ed6..c5b91f5bf069a922bc342e039299f0fe3a0605db 100644
--- a/media/cast/sender/congestion_control.cc
+++ b/media/cast/sender/congestion_control.cc
@@ -38,10 +38,10 @@ class AdaptiveCongestionControl : public CongestionControl {
// CongestionControl implementation.
void UpdateRtt(base::TimeDelta rtt) final;
void UpdateTargetPlayoutDelay(base::TimeDelta delay) final;
- void SendFrameToTransport(uint32 frame_id,
+ void SendFrameToTransport(uint32_t frame_id,
size_t frame_size_in_bits,
base::TimeTicks when) final;
- void AckFrame(uint32 frame_id, base::TimeTicks when) final;
+ void AckFrame(uint32_t frame_id, base::TimeTicks when) final;
int GetBitrate(base::TimeTicks playout_time,
base::TimeDelta playout_delay,
int soft_max_bitrate) final;
@@ -61,7 +61,7 @@ class AdaptiveCongestionControl : public CongestionControl {
static base::TimeDelta DeadTime(const FrameStats& a, const FrameStats& b);
// Get the FrameStats for a given |frame_id|. Never returns nullptr.
// Note: Older FrameStats will be removed automatically.
- FrameStats* GetFrameStats(uint32 frame_id);
+ FrameStats* GetFrameStats(uint32_t frame_id);
// Discard old FrameStats.
void PruneFrameStats();
// Calculate a safe bitrate. This is based on how much we've been
@@ -71,7 +71,7 @@ class AdaptiveCongestionControl : public CongestionControl {
// Estimate when the transport will start sending the data for a given frame.
// |estimated_bitrate| is the current estimated transmit bitrate in bits per
// second.
- base::TimeTicks EstimatedSendingTime(uint32 frame_id,
+ base::TimeTicks EstimatedSendingTime(uint32_t frame_id,
double estimated_bitrate);
base::TickClock* const clock_; // Not owned by this class.
@@ -79,9 +79,9 @@ class AdaptiveCongestionControl : public CongestionControl {
const int min_bitrate_configured_;
const double max_frame_rate_;
std::deque<FrameStats> frame_stats_;
- uint32 last_frame_stats_;
- uint32 last_acked_frame_;
- uint32 last_enqueued_frame_;
+ uint32_t last_frame_stats_;
+ uint32_t last_acked_frame_;
+ uint32_t last_enqueued_frame_;
base::TimeDelta rtt_;
size_t history_size_;
size_t acked_bits_in_history_;
@@ -98,10 +98,10 @@ class FixedCongestionControl : public CongestionControl {
// CongestionControl implementation.
void UpdateRtt(base::TimeDelta rtt) final {}
void UpdateTargetPlayoutDelay(base::TimeDelta delay) final {}
- void SendFrameToTransport(uint32 frame_id,
+ void SendFrameToTransport(uint32_t frame_id,
size_t frame_size_in_bits,
base::TimeTicks when) final {}
- void AckFrame(uint32 frame_id, base::TimeTicks when) final {}
+ void AckFrame(uint32_t frame_id, base::TimeTicks when) final {}
int GetBitrate(base::TimeTicks playout_time,
base::TimeDelta playout_delay,
int soft_max_bitrate) final {
@@ -143,18 +143,17 @@ static const size_t kHistorySize = 100;
AdaptiveCongestionControl::FrameStats::FrameStats() : frame_size_in_bits(0) {
}
-AdaptiveCongestionControl::AdaptiveCongestionControl(
- base::TickClock* clock,
- int max_bitrate_configured,
- int min_bitrate_configured,
- double max_frame_rate)
+AdaptiveCongestionControl::AdaptiveCongestionControl(base::TickClock* clock,
+ int max_bitrate_configured,
+ int min_bitrate_configured,
+ double max_frame_rate)
: clock_(clock),
max_bitrate_configured_(max_bitrate_configured),
min_bitrate_configured_(min_bitrate_configured),
max_frame_rate_(max_frame_rate),
- last_frame_stats_(static_cast<uint32>(-1)),
- last_acked_frame_(static_cast<uint32>(-1)),
- last_enqueued_frame_(static_cast<uint32>(-1)),
+ last_frame_stats_(static_cast<uint32_t>(-1)),
+ last_acked_frame_(static_cast<uint32_t>(-1)),
+ last_enqueued_frame_(static_cast<uint32_t>(-1)),
history_size_(kHistorySize),
acked_bits_in_history_(0) {
DCHECK_GE(max_bitrate_configured, min_bitrate_configured) << "Invalid config";
@@ -205,10 +204,10 @@ double AdaptiveCongestionControl::CalculateSafeBitrate() {
return acked_bits_in_history_ / std::max(transmit_time, 1E-3);
}
-AdaptiveCongestionControl::FrameStats*
-AdaptiveCongestionControl::GetFrameStats(uint32 frame_id) {
- int32 offset = static_cast<int32>(frame_id - last_frame_stats_);
- DCHECK_LT(offset, static_cast<int32>(kHistorySize));
+AdaptiveCongestionControl::FrameStats* AdaptiveCongestionControl::GetFrameStats(
+ uint32_t frame_id) {
+ int32_t offset = static_cast<int32_t>(frame_id - last_frame_stats_);
+ DCHECK_LT(offset, static_cast<int32_t>(kHistorySize));
if (offset > 0) {
frame_stats_.resize(frame_stats_.size() + offset);
last_frame_stats_ += offset;
@@ -218,7 +217,7 @@ AdaptiveCongestionControl::GetFrameStats(uint32 frame_id) {
offset += frame_stats_.size() - 1;
// TODO(miu): Change the following to DCHECK once crash fix is confirmed.
// http://crbug.com/517145
- CHECK(offset >= 0 && offset < static_cast<int32>(frame_stats_.size()));
+ CHECK(offset >= 0 && offset < static_cast<int32_t>(frame_stats_.size()));
return &frame_stats_[offset];
}
@@ -235,7 +234,7 @@ void AdaptiveCongestionControl::PruneFrameStats() {
}
}
-void AdaptiveCongestionControl::AckFrame(uint32 frame_id,
+void AdaptiveCongestionControl::AckFrame(uint32_t frame_id,
base::TimeTicks when) {
FrameStats* frame_stats = GetFrameStats(last_acked_frame_);
while (IsNewerFrameId(frame_id, last_acked_frame_)) {
@@ -255,7 +254,7 @@ void AdaptiveCongestionControl::AckFrame(uint32 frame_id,
}
}
-void AdaptiveCongestionControl::SendFrameToTransport(uint32 frame_id,
+void AdaptiveCongestionControl::SendFrameToTransport(uint32_t frame_id,
size_t frame_size_in_bits,
base::TimeTicks when) {
last_enqueued_frame_ = frame_id;
@@ -265,7 +264,7 @@ void AdaptiveCongestionControl::SendFrameToTransport(uint32 frame_id,
}
base::TimeTicks AdaptiveCongestionControl::EstimatedSendingTime(
- uint32 frame_id,
+ uint32_t frame_id,
double estimated_bitrate) {
const base::TimeTicks now = clock_->NowTicks();
@@ -277,7 +276,7 @@ base::TimeTicks AdaptiveCongestionControl::EstimatedSendingTime(
// be in-flight; and therefore it is common for the |estimated_sending_time|
// for those frames to be before |now|.
base::TimeTicks estimated_sending_time;
- for (uint32 f = last_acked_frame_; IsNewerFrameId(frame_id, f); ++f) {
+ for (uint32_t f = last_acked_frame_; IsNewerFrameId(frame_id, f); ++f) {
FrameStats* const stats = GetFrameStats(f);
// |estimated_ack_time| is the local time when the sender receives the ACK,

Powered by Google App Engine
This is Rietveld 408576698