Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1534223002: fix large dashed paths (Closed)

Created:
5 years ago by caryclark
Modified:
5 years ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix large dashed paths Paths with lots of points exceed the 32767 point index. Make the index larger, add a test, and allow the t value to use the extra bits. R=reed@google.com,fmalita@chromium.org BUG=skia:3501 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1534223002 Committed: https://skia.googlesource.com/skia/+/f97aa74fea0133378e64700e30a7c2962212fcb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M gm/dashing.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
M include/core/SkPathMeasure.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/core/SkPathMeasure.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534223002/1
5 years ago (2015-12-18 14:30:59 UTC) #3
caryclark
5 years ago (2015-12-18 14:31:07 UTC) #4
reed1
lgtm
5 years ago (2015-12-18 14:33:12 UTC) #5
f(malita)
lgtm
5 years ago (2015-12-18 14:37:14 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 14:50:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534223002/1
5 years ago (2015-12-18 15:02:38 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-18 15:03:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f97aa74fea0133378e64700e30a7c2962212fcb5

Powered by Google App Engine
This is Rietveld 408576698