remoting/protocol/channel_dispatcher_base.cc - Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/channel_dispatcher_base.cc

Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/channel_dispatcher_base.cc

diff --git a/remoting/protocol/channel_dispatcher_base.cc b/remoting/protocol/channel_dispatcher_base.cc

index 0b7411f29af01382a5f1e4f6dc71479c2b418a85..28aeae3676cd005397ed7baa46d2d9c7546607fa 100644

--- a/remoting/protocol/channel_dispatcher_base.cc

+++ b/remoting/protocol/channel_dispatcher_base.cc

@@ -39,7 +39,7 @@ void ChannelDispatcherBase::OnChannelReady(

}

channel_factory_ = nullptr;

- channel_ = socket.Pass();

+ channel_ = std::move(socket);

writer_.Init(

base::Bind(&P2PStreamSocket::Write, base::Unretained(channel_.get())),

base::Bind(&ChannelDispatcherBase::OnReadWriteFailed,