chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc - Issue 1534173003: ChromeOS user_manager: move all KnownUser code to separate file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 1534173003: ChromeOS user_manager: move all KnownUser code to separate file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/FindUsingSAML/IsUsingSAML/ Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/user_image_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

index b1cb3c2734e25ad899b7ffecfeba4220beb863ed..e20843831bf0668e6d5b6f550ed8866b7211967e 100644

--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

@@ -69,6 +69,7 @@

#include "chromeos/network/network_state_handler.h"

#include "components/login/localized_values_builder.h"

#include "components/proximity_auth/screenlock_bridge.h"

+#include "components/user_manager/known_user.h"

#include "components/user_manager/user.h"

#include "components/user_manager/user_manager.h"

#include "components/user_manager/user_type.h"

@@ -1230,7 +1231,7 @@ void SigninScreenHandler::HandleFocusPod(const AccountId& account_id) {

test_focus_pod_callback_.Run();

bool use_24hour_clock = false;

- if (user_manager::UserManager::Get()->GetKnownUserBooleanPref(

+ if (user_manager::known_user::GetBooleanPref(

account_id, prefs::kUse24HourClock, &use_24hour_clock)) {

g_browser_process->platform_part()

->GetSystemClock()

@@ -1282,7 +1283,7 @@ void SigninScreenHandler::HandleFirstIncorrectPasswordAttempt(

const AccountId& account_id) {

// TODO(ginkage): Fix this case once crbug.com/469987 is ready.

- if (user_manager::UserManager::Get()->FindUsingSAML(email))

+ if (user_manager::known_user::IsUsingSAML(email))

RecordReauthReason(email, ReauthReason::INCORRECT_SAML_PASSWORD_ENTERED);

}