Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1534173003: ChromeOS user_manager: move all KnownUser code to separate file. (Closed)

Created:
5 years ago by Alexander Alekseev
Modified:
5 years ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS user_manager: move all KnownUser code to separate file. Include components/user_manager/user_manager.h has become too heavy. This CL moves all KnownUser stuff to a new known_user.{cc,h} so that we do not need to include all user_manager if only known_user is needed. BUG=462823 TEST=manual Committed: https://crrev.com/8730a2f5c288b835a9050c5ec73416898d7f7732 Cr-Commit-Position: refs/heads/master@{#366274}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Patch Set 3 : Fix component build. #

Patch Set 4 : Add empty line. #

Total comments: 2

Patch Set 5 : s/KnownUser// #

Patch Set 6 : s/FindUsingSAML/IsUsingSAML/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+567 lines, -575 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/bootstrap_manager.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_factory.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/reauth_stats.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc View 1 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 2 3 4 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 3 4 6 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/signin/device_id_browsertest.cc View 1 2 3 4 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signin/token_handle_util.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/chromeos/login/signin/token_handle_util.cc View 1 2 3 4 6 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 2 3 4 6 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 1 2 3 4 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 3 4 5 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M components/user_manager.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/user_manager/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/user_manager/known_user.h View 1 2 3 4 5 1 chunk +132 lines, -0 lines 0 comments Download
A components/user_manager/known_user.cc View 1 2 3 4 5 1 chunk +334 lines, -0 lines 0 comments Download
M components/user_manager/user_manager.h View 2 chunks +3 lines, -103 lines 0 comments Download
M components/user_manager/user_manager.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M components/user_manager/user_manager_base.h View 3 chunks +0 lines, -46 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 2 3 4 5 10 chunks +6 lines, -290 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
Alexander Alekseev
This is only a code refactoring. Nothing has been added or removed. Please review. dzhioev@ ...
5 years ago (2015-12-18 12:16:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534173003/1
5 years ago (2015-12-18 12:16:39 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/72458)
5 years ago (2015-12-18 12:31:00 UTC) #6
Roger Tawa OOO till Jul 10th
c/b/s lgtm https://codereview.chromium.org/1534173003/diff/1/components/user_manager/known_user.h File components/user_manager/known_user.h (right): https://codereview.chromium.org/1534173003/diff/1/components/user_manager/known_user.h#newcode105 components/user_manager/known_user.h:105: bool FindUsingSAML(const AccountId& account_id); Nit: rename to ...
5 years ago (2015-12-18 16:41:26 UTC) #7
stevenjb
c/b/chromeos lgtm
5 years ago (2015-12-18 17:07:21 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534173003/20001
5 years ago (2015-12-18 23:56:25 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/136239)
5 years ago (2015-12-19 00:45:37 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534173003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534173003/40001
5 years ago (2015-12-19 01:35:48 UTC) #14
dzhioev (left Google)
https://codereview.chromium.org/1534173003/diff/60001/components/user_manager/known_user.h File components/user_manager/known_user.h (right): https://codereview.chromium.org/1534173003/diff/60001/components/user_manager/known_user.h#newcode29 components/user_manager/known_user.h:29: FindKnownUserPrefs(const AccountId& account_id, Since all these methods are inside ...
5 years ago (2015-12-19 03:26:58 UTC) #15
Alexander Alekseev
https://codereview.chromium.org/1534173003/diff/1/components/user_manager/known_user.h File components/user_manager/known_user.h (right): https://codereview.chromium.org/1534173003/diff/1/components/user_manager/known_user.h#newcode105 components/user_manager/known_user.h:105: bool FindUsingSAML(const AccountId& account_id); On 2015/12/18 16:41:26, Roger Tawa ...
5 years ago (2015-12-19 05:46:39 UTC) #16
Alexander Alekseev
https://codereview.chromium.org/1534173003/diff/1/components/user_manager/known_user.h File components/user_manager/known_user.h (right): https://codereview.chromium.org/1534173003/diff/1/components/user_manager/known_user.h#newcode105 components/user_manager/known_user.h:105: bool FindUsingSAML(const AccountId& account_id); On 2015/12/18 16:41:26, Roger Tawa ...
5 years ago (2015-12-19 05:46:40 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534173003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534173003/100001
5 years ago (2015-12-19 05:47:15 UTC) #19
dzhioev (left Google)
LGTM
5 years ago (2015-12-19 06:04:55 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-19 06:54:02 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534173003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534173003/100001
5 years ago (2015-12-19 07:08:47 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-19 07:13:17 UTC) #26
commit-bot: I haz the power
5 years ago (2015-12-19 07:14:14 UTC) #28
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/8730a2f5c288b835a9050c5ec73416898d7f7732
Cr-Commit-Position: refs/heads/master@{#366274}

Powered by Google App Engine
This is Rietveld 408576698