Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3574)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h
index f88d3dc3284e9271e9414e3cddd87c5ab727dd76..e9063864de7941034c24bc6aed1da64c165b44bb 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h
@@ -21,8 +21,18 @@ namespace content {
class PageNavigator;
}
+class ExtensionInstallViewDelegate {
+ public:
+ virtual void OnOkButtonClicked() = 0;
+ virtual void OnCancelButtonClicked() = 0;
+ virtual void OnStoreLinkClicked() = 0;
+
+ protected:
+ virtual ~ExtensionInstallViewDelegate() {}
+};
+
// Displays the extension or bundle install prompt, and notifies the
-// ExtensionInstallPrompt::Delegate of success or failure
+// Delegate of success or failure.
@interface ExtensionInstallViewController : NSViewController
<NSOutlineViewDataSource,
NSOutlineViewDelegate> {
@@ -45,7 +55,7 @@ class PageNavigator;
Profile* profile_; // weak
content::PageNavigator* navigator_; // weak
- ExtensionInstallPrompt::Delegate* delegate_; // weak
+ ExtensionInstallViewDelegate* delegate_; // weak
scoped_ptr<ExtensionInstallPrompt::Prompt> prompt_;
base::scoped_nsobject<NSArray> warnings_;
@@ -67,7 +77,7 @@ class PageNavigator;
- (id)initWithProfile:(Profile*)profile
navigator:(content::PageNavigator*)navigator
- delegate:(ExtensionInstallPrompt::Delegate*)delegate
+ delegate:(ExtensionInstallViewDelegate*)delegate
prompt:(scoped_ptr<ExtensionInstallPrompt::Prompt>)prompt;
- (IBAction)storeLinkClicked:(id)sender; // Callback for "View details" link.
- (IBAction)cancel:(id)sender;

Powered by Google App Engine
This is Rietveld 408576698