Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3190)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h

Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
index 0596b00c07b020611bc79c9c93a5d2752beb8149..26143ea58e21910cc2e21dfec846ad25caa391bd 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "chrome/browser/extensions/extension_install_prompt.h"
#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"
+#import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"
namespace content {
class PageNavigator;
@@ -26,18 +27,19 @@ class ExtensionInstallPromptShowParams;
// Displays an extension install prompt as a tab modal dialog.
class ExtensionInstallDialogController :
- public ExtensionInstallPrompt::Delegate,
+ public ExtensionInstallViewDelegate,
public ConstrainedWindowMacDelegate {
public:
ExtensionInstallDialogController(
ExtensionInstallPromptShowParams* show_params,
- ExtensionInstallPrompt::Delegate* delegate,
+ const ExtensionInstallPrompt::DoneCallback& done_callback,
scoped_ptr<ExtensionInstallPrompt::Prompt> prompt);
~ExtensionInstallDialogController() override;
- // ExtensionInstallPrompt::Delegate implementation.
- void InstallUIProceed() override;
- void InstallUIAbort(bool user_initiated) override;
+ // ExtensionInstallViewDelegate implementation.
+ void OnOkButtonClicked() override;
+ void OnCancelButtonClicked() override;
+ void OnStoreLinkClicked() override;
// ConstrainedWindowMacDelegate implementation.
void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override;
@@ -50,7 +52,10 @@ class ExtensionInstallDialogController :
}
private:
- ExtensionInstallPrompt::Delegate* delegate_;
+ void OnPromptButtonClicked(ExtensionInstallPrompt::Result result,
+ const char* decision_event);
+
+ ExtensionInstallPrompt::DoneCallback done_callback_;
base::scoped_nsobject<ExtensionInstallViewController> view_controller_;
scoped_ptr<ConstrainedWindowMac> constrained_window_;
scoped_ptr<extensions::ExperienceSamplingEvent> sampling_event_;

Powered by Google App Engine
This is Rietveld 408576698