Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5200)

Unified Diff: chrome/browser/extensions/external_install_error.h

Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_install_error.h
diff --git a/chrome/browser/extensions/external_install_error.h b/chrome/browser/extensions/external_install_error.h
index ccad2d3d91e856a8e822426dd8bf067d1caf97b8..6d6c2a64d0a9cb729f7febdbeee837f00c2d0e5f 100644
--- a/chrome/browser/extensions/external_install_error.h
+++ b/chrome/browser/extensions/external_install_error.h
@@ -33,8 +33,7 @@ class WebstoreDataFetcher;
// possible) and will handle adding itself to the GlobalErrorService when
// initialized and removing itself from the GlobalErrorService upon
// destruction.
-class ExternalInstallError : public ExtensionInstallPrompt::Delegate,
- public WebstoreDataFetcherDelegate {
+class ExternalInstallError : public WebstoreDataFetcherDelegate {
public:
// The possible types of errors to show. A menu alert adds a menu item to the
// wrench, which spawns an extension install dialog when clicked. The bubble
@@ -51,9 +50,7 @@ class ExternalInstallError : public ExtensionInstallPrompt::Delegate,
ExternalInstallManager* manager);
~ExternalInstallError() override;
- // ExtensionInstallPrompt::Delegate implementation.
- void InstallUIProceed() override;
- void InstallUIAbort(bool user_initiated) override;
+ void OnInstallPromptDone(ExtensionInstallPrompt::Result result);
// Show the associated dialog. This should only be called once the dialog is
// ready.
@@ -78,7 +75,7 @@ class ExternalInstallError : public ExtensionInstallPrompt::Delegate,
// Called when the dialog has been successfully populated, and is ready to be
// shown.
void OnDialogReady(ExtensionInstallPromptShowParams* show_params,
- ExtensionInstallPrompt::Delegate* prompt_delegate,
+ const ExtensionInstallPrompt::DoneCallback& done_callback,
scoped_ptr<ExtensionInstallPrompt::Prompt> prompt);
// The associated BrowserContext.
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/external_install_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698